gpu: Update ANGLE Platform integration.

gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

Must be landed after https://chromium-review.googlesource.com/c/441273/

BUG=chromium:678870
R=jbauman@chromium.org, kbr@chromium.org

Review-Url: https://codereview.chromium.org/2697463003
Cr-Commit-Position: refs/heads/master@{#450394}
Committed: https://chromium.googlesource.com/chromium/src/+/98835277ee20b81f876857e87bbb7081a5e722b2

[Jamie Madill, 2017-02-13 18:44:34]

Description was changed from

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

BUG=chromium:678870
R=jbauman@chromium.org
==========

to

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

BUG=chromium:678870
R=jbauman@chromium.org
==========

[Jamie Madill, 2017-02-13 18:44:34]

jmadill@chromium.org changed reviewers:
+ kbr@chromium.org

[Jamie Madill, 2017-02-13 18:44:43]

Description was changed from

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

BUG=chromium:678870
R=jbauman@chromium.org
==========

to

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

BUG=chromium:678870
R=jbauman@chromium.org, kbr@chromium.org
==========

[Jamie Madill, 2017-02-13 18:45:02]

John or Ken PTAL. Must be landed after
https://chromium-review.googlesource.com/c/441273/ rolls into Chromium.

[jbauman, 2017-02-13 23:32:25]

lgtm

[Ken Russell (switch to Gerrit), 2017-02-13 23:39:13]

LGTM with one question.

https://codereview.chromium.org/2697463003/diff/1/ui/gl/angle_platform_impl.cc
File ui/gl/angle_platform_impl.cc (right):

https://codereview.chromium.org/2697463003/diff/1/ui/gl/angle_platform_impl.c...
ui/gl/angle_platform_impl.cc:120: angle::g_NumPlatformMethods,
&platformMethods))
I assume this fails if the structure's changed size (or number of platform
methods) since the last time the code was compiled? Not seeing the definition of
angle_get_platform in code search. Would be helpful if you could link to it in
the CL description, since the bug is inaccessible.

[Ken Russell (switch to Gerrit), 2017-02-13 23:40:18]

https://codereview.chromium.org/2697463003/diff/1/ui/gl/angle_platform_impl.cc
File ui/gl/angle_platform_impl.cc (right):

https://codereview.chromium.org/2697463003/diff/1/ui/gl/angle_platform_impl.c...
ui/gl/angle_platform_impl.cc:120: angle::g_NumPlatformMethods,
&platformMethods))
On 2017/02/13 23:39:13, Ken Russell wrote:
> I assume this fails if the structure's changed size (or number of platform
> methods) since the last time the code was compiled? Not seeing the definition
of
> angle_get_platform in code search. Would be helpful if you could link to it in
> the CL description, since the bug is inaccessible.

Ah, I see now that you linked to it in the first message on this code review.
Please use the CL description in the future for important information like that.

[Jamie Madill, 2017-02-14 14:30:16]

Description was changed from

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

BUG=chromium:678870
R=jbauman@chromium.org, kbr@chromium.org
==========

to

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

Must be landed after https://chromium-review.googlesource.com/c/441273/

BUG=chromium:678870
R=jbauman@chromium.org, kbr@chromium.org
==========

[Jamie Madill, 2017-02-14 14:32:09]

On 2017/02/13 23:40:18, Ken Russell wrote:
> https://codereview.chromium.org/2697463003/diff/1/ui/gl/angle_platform_impl.cc
> File ui/gl/angle_platform_impl.cc (right):
> 
>
https://codereview.chromium.org/2697463003/diff/1/ui/gl/angle_platform_impl.c...
> ui/gl/angle_platform_impl.cc:120: angle::g_NumPlatformMethods,
> &platformMethods))
> On 2017/02/13 23:39:13, Ken Russell wrote:
> > I assume this fails if the structure's changed size (or number of platform
> > methods) since the last time the code was compiled? Not seeing the
definition
> of
> > angle_get_platform in code search. Would be helpful if you could link to it
in
> > the CL description, since the bug is inaccessible.
> 
> Ah, I see now that you linked to it in the first message on this code review.
> Please use the CL description in the future for important information like
that.

Linked, thanks for reviews.

[Jamie Madill, 2017-02-14 14:32:12]

The CQ bit was checked by jmadill@chromium.org

[Jamie Madill, 2017-02-14 14:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2697463003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-14 14:32:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 14:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 14:57:17]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Jamie Madill, 2017-02-14 15:24:34]

On 2017/02/14 14:57:17, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Investigating failures now..

[Jamie Madill, 2017-02-14 16:22:58]

The CQ bit was checked by jmadill@chromium.org

[Jamie Madill, 2017-02-14 16:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2697463003/#ps40001
(title: "Fix crash in Reset")

[commit-bot: I haz the power, 2017-02-14 16:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 17:27:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487089378654750,
"parent_rev": "8b7660a8c98d3776aa9834e4f35470d1f8919376", "commit_rev":
"98835277ee20b81f876857e87bbb7081a5e722b2"}

[commit-bot: I haz the power, 2017-02-14 17:28:10]

Description was changed from

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

Must be landed after https://chromium-review.googlesource.com/c/441273/

BUG=chromium:678870
R=jbauman@chromium.org, kbr@chromium.org
==========

to

==========
gpu: Update ANGLE Platform integration.

The new methods use a C-style API to fix undefined behaviour across
module boundaries. They also associate the platform with an EGL
display, instead of using an ANGLE-global variable.

Must be landed after https://chromium-review.googlesource.com/c/441273/

BUG=chromium:678870
R=jbauman@chromium.org, kbr@chromium.org

Review-Url: https://codereview.chromium.org/2697463003
Cr-Commit-Position: refs/heads/master@{#450394}
Committed:
https://chromium.googlesource.com/chromium/src/+/98835277ee20b81f876857e87bbb...
==========

[commit-bot: I haz the power, 2017-02-14 17:28:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/98835277ee20b81f876857e87bbb...