Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: ui/gl/gl_surface_egl.cc

Issue 2697463003: gpu: Update ANGLE Platform integration. (Closed)
Patch Set: Fix crash in Reset Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/angle_platform_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface_egl.cc
diff --git a/ui/gl/gl_surface_egl.cc b/ui/gl/gl_surface_egl.cc
index 2e1cffffe094e5335e9f285a55457729134ea19b..c17892fb1274eadae8dcf0db4a6076173e38b328 100644
--- a/ui/gl/gl_surface_egl.cc
+++ b/ui/gl/gl_surface_egl.cc
@@ -136,10 +136,6 @@ bool g_egl_surfaceless_context_supported = false;
bool g_egl_surface_orientation_supported = false;
bool g_use_direct_composition = false;
-base::LazyInstance<ANGLEPlatformImpl> g_angle_platform_impl =
- LAZY_INSTANCE_INITIALIZER;
-ANGLEPlatformShutdownFunc g_angle_platform_shutdown = nullptr;
-
EGLDisplay GetPlatformANGLEDisplay(EGLNativeDisplayType native_display,
EGLenum platform_type,
bool warpDevice) {
@@ -549,9 +545,7 @@ bool GLSurfaceEGL::InitializeOneOff(EGLNativeDisplayType native_display) {
// static
void GLSurfaceEGL::ShutdownOneOff() {
- if (g_angle_platform_shutdown) {
- g_angle_platform_shutdown();
- }
+ ResetANGLEPlatform(g_display);
if (g_display != EGL_NO_DISPLAY)
eglTerminate(g_display);
@@ -626,17 +620,6 @@ EGLDisplay GLSurfaceEGL::InitializeDisplay(
g_native_display = native_display;
- // Init ANGLE platform here, before we call GetPlatformDisplay().
- ANGLEPlatformInitializeFunc angle_platform_init =
- reinterpret_cast<ANGLEPlatformInitializeFunc>(
- eglGetProcAddress("ANGLEPlatformInitialize"));
- if (angle_platform_init) {
- angle_platform_init(&g_angle_platform_impl.Get());
-
- g_angle_platform_shutdown = reinterpret_cast<ANGLEPlatformShutdownFunc>(
- eglGetProcAddress("ANGLEPlatformShutdown"));
- }
-
// If EGL_EXT_client_extensions not supported this call to eglQueryString
// will return NULL.
const char* client_extensions =
@@ -670,6 +653,11 @@ EGLDisplay GLSurfaceEGL::InitializeDisplay(
<< GetLastEGLErrorString();
}
+ // Init ANGLE platform now that we have the global display.
+ if (!InitializeANGLEPlatform(display)) {
+ LOG(ERROR) << "ANGLE Platform initialization failed.";
+ }
+
if (!eglInitialize(display, nullptr, nullptr)) {
bool is_last = disp_index == init_displays.size() - 1;
« no previous file with comments | « ui/gl/angle_platform_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698