[MD settings] expand subpages to 100%

[MD settings] expand subpages to 100%

This CL changes a node that was a template prior to CL 266038002, back
into being a template. In CL 266038002 I had changed the template to a
div, which affects how the CSS is applied (breaking the subpage height).

BUG=690551
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2697453008
Cr-Commit-Position: refs/heads/master@{#450535}
Committed: https://chromium.googlesource.com/chromium/src/+/0178428f6e9f682eb526fe95b78374448f40d9ff

[dschuyler, 2017-02-14 01:40:26]

Description was changed from

==========
[MD settings] expand subpages to 100%

This CL changes a node that was a template prior to CL 266038002, back
into being a template. In CL 266038002 I had changed the template to a
div, which affects how the CSS is applied (breaking the subpage height).

BUG=690551
==========

to

==========
[MD settings] expand subpages to 100%

This CL changes a node that was a template prior to CL 266038002, back
into being a template. In CL 266038002 I had changed the template to a
div, which affects how the CSS is applied (breaking the subpage height).

BUG=690551
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-02-14 01:40:28]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:41:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-14 02:05:31]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 02:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:40:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 04:40:46]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-14 18:50:22]

Patchset #1 (id:1) has been deleted

[dschuyler, 2017-02-14 18:51:01]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2017-02-14 19:06:00]

https://codereview.chromium.org/2697453008/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/basic_page/basic_page.js (right):

https://codereview.chromium.org/2697453008/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/basic_page/basic_page.js:141:
Polymer.dom.flush();
We've been generally avoiding calling Polymer.dom.flush() in prod code (there
are 3 occurrences of such calls). Is this call necessary? Does the following
work equivalently?

if (this.advancedToggleExpanded) {
  this.async(function() {
    this.$$('#advancedPageTemplate').get();
  }.bind(this));
}

[dschuyler, 2017-02-14 19:35:14]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 19:35:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-14 19:36:56]

Good idea, thanks.

https://codereview.chromium.org/2697453008/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/basic_page/basic_page.js (right):

https://codereview.chromium.org/2697453008/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/basic_page/basic_page.js:141:
Polymer.dom.flush();
On 2017/02/14 19:06:00, dpapad wrote:
> We've been generally avoiding calling Polymer.dom.flush() in prod code (there
> are 3 occurrences of such calls). Is this call necessary? Does the following
> work equivalently?
> 
> if (this.advancedToggleExpanded) {
>   this.async(function() {
>     this.$$('#advancedPageTemplate').get();
>   }.bind(this));
> }

Done.

[dpapad, 2017-02-14 19:49:34]

lgtm

[commit-bot: I haz the power, 2017-02-14 20:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:42:35]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-15 00:05:58]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:06:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487117158548390,
"parent_rev": "ac6bbf510624dc7116c6ad4ce489a42b9e6111aa", "commit_rev":
"0178428f6e9f682eb526fe95b78374448f40d9ff"}

[commit-bot: I haz the power, 2017-02-15 01:16:00]

Description was changed from

==========
[MD settings] expand subpages to 100%

This CL changes a node that was a template prior to CL 266038002, back
into being a template. In CL 266038002 I had changed the template to a
div, which affects how the CSS is applied (breaking the subpage height).

BUG=690551
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] expand subpages to 100%

This CL changes a node that was a template prior to CL 266038002, back
into being a template. In CL 266038002 I had changed the template to a
div, which affects how the CSS is applied (breaking the subpage height).

BUG=690551
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2697453008
Cr-Commit-Position: refs/heads/master@{#450535}
Committed:
https://chromium.googlesource.com/chromium/src/+/0178428f6e9f682eb526fe95b783...
==========

[commit-bot: I haz the power, 2017-02-15 01:16:01]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0178428f6e9f682eb526fe95b783...