Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2697453008: [MD settings] expand subpages to 100% (Closed)
Patch Set: async Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index 82e9add52da31876ba558caf8c8a3136501948d6..02074331ff3f9561c6e90bcabdecea75c994c4d0 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -102,7 +102,7 @@ Polymer({
if (this.pageVisibility.advancedSettings !== false) {
assert(whenSearchDone === settings.getSearchManager().search(
- query, assert(this.$.advancedPageTemplate.get())));
+ query, assert(this.$$('#advancedPageTemplate').get())));
}
return whenSearchDone;
@@ -136,8 +136,11 @@ Polymer({
* @private
*/
advancedToggleExpandedChanged_: function() {
- if (this.advancedToggleExpanded)
- this.$.advancedPageTemplate.get();
+ if (this.advancedToggleExpanded) {
+ this.async(function() {
+ this.$$('#advancedPageTemplate').get();
+ }.bind(this));
+ }
},
/**
« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.html ('k') | chrome/test/data/webui/settings/settings_main_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698