Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2697333002: Add caching for task counts (Closed)

Created:
3 years, 10 months ago by kjlubick
Modified:
3 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add caching for task counts The UI only allows for selection to the nearest minute, so memcache assumes the end timestamp is also at a minute resolution. BUG=673774 Review-Url: https://codereview.chromium.org/2697333002 Committed: https://github.com/luci/luci-py/commit/61230b5f8392628a96ce30eb1d1c1379e78b9cff

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add namespace #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M appengine/swarming/handlers_endpoints.py View 1 2 chunks +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
kjlubick
3 years, 10 months ago (2017-02-16 16:26:52 UTC) #2
M-A Ruel
lgtm with fixes https://codereview.chromium.org/2697333002/diff/1/appengine/swarming/handlers_endpoints.py File appengine/swarming/handlers_endpoints.py (right): https://codereview.chromium.org/2697333002/diff/1/appengine/swarming/handlers_endpoints.py#newcode11 appengine/swarming/handlers_endpoints.py:11: from google.appengine.api import memcache as gae_memcache ...
3 years, 10 months ago (2017-02-16 18:15:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697333002/40001
3 years, 10 months ago (2017-02-17 14:49:24 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://github.com/luci/luci-py/commit/61230b5f8392628a96ce30eb1d1c1379e78b9cff
3 years, 10 months ago (2017-02-17 14:53:23 UTC) #9
kjlubick
3 years, 10 months ago (2017-02-17 15:54:50 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2697333002/diff/1/appengine/swarming/handlers...
File appengine/swarming/handlers_endpoints.py (right):

https://codereview.chromium.org/2697333002/diff/1/appengine/swarming/handlers...
appengine/swarming/handlers_endpoints.py:11: from google.appengine.api import
memcache as gae_memcache
On 2017/02/16 at 18:15:19, M-A Ruel wrote:
> why rename?

It was to be consistent with components/utils.py.  I'll un-rename it.

https://codereview.chromium.org/2697333002/diff/1/appengine/swarming/handlers...
appengine/swarming/handlers_endpoints.py:522: gae_memcache.add(mem_key, count,
120)
On 2017/02/16 at 18:15:19, M-A Ruel wrote:
> technically the entry is valid for a while since you encode the end time, you
could use 24*60*60 as the expiration.

Done

Powered by Google App Engine
This is Rietveld 408576698