Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2696613007: Add the ability to filter by time to task list. (Closed)

Created:
3 years, 10 months ago by kjlubick
Modified:
3 years, 10 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add the ability to filter by time to task list. Also optimize the task-list to look better at 1200px width. BUG=684563 Review-Url: https://codereview.chromium.org/2696613007 Committed: https://github.com/luci/luci-py/commit/ff0ee7ec014926370e98e576f767f0381d18c2c1

Patch Set 1 #

Patch Set 2 : Get task-list-summary to use times also #

Patch Set 3 : Fix _makeURL #

Total comments: 4

Patch Set 4 : Add lots of docs and rework setDate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -232 lines) Patch
M appengine/swarming/ui/bower.json View 1 chunk +3 lines, -1 line 0 comments Download
M appengine/swarming/ui/build/elements.html View 1 2 3 3 chunks +10 lines, -195 lines 0 comments Download
M appengine/swarming/ui/res/imp/index/swarming-index.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-filters.html View 1 2 3 12 chunks +214 lines, -6 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list.html View 1 2 3 5 chunks +64 lines, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list-demo.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list-summary.html View 1 2 3 5 chunks +34 lines, -27 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
kjlubick
See it live at https://2637-d8a3c8d-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/tasklist Screencast: https://screencast.googleplex.com/cast/NTkxMTkzMjY1NzcyOTUzNnwzNTNlNzE4ZC1lYQ Here's a screenshot at 1200px: https://screenshot.googleplex.com/0BjUfOxjXcO
3 years, 10 months ago (2017-02-16 15:40:00 UTC) #2
stephana-chromium
https://codereview.chromium.org/2696613007/diff/40001/appengine/swarming/ui/res/imp/tasklist/task-filters.html File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right): https://codereview.chromium.org/2696613007/diff/40001/appengine/swarming/ui/res/imp/tasklist/task-filters.html#newcode232 appengine/swarming/ui/res/imp/tasklist/task-filters.html:232: ts = ts || "1"; Nit: _parseTS would make ...
3 years, 10 months ago (2017-02-16 18:32:03 UTC) #3
kjlubick
https://codereview.chromium.org/2696613007/diff/40001/appengine/swarming/ui/res/imp/tasklist/task-filters.html File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right): https://codereview.chromium.org/2696613007/diff/40001/appengine/swarming/ui/res/imp/tasklist/task-filters.html#newcode232 appengine/swarming/ui/res/imp/tasklist/task-filters.html:232: ts = ts || "1"; On 2017/02/16 at 18:32:03, ...
3 years, 10 months ago (2017-02-17 14:13:33 UTC) #4
stephana
LGTM
3 years, 10 months ago (2017-02-17 14:35:04 UTC) #6
KevinL
lgtm
3 years, 10 months ago (2017-02-17 14:38:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696613007/60001
3 years, 10 months ago (2017-02-17 14:38:24 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 14:42:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/ff0ee7ec014926370e98e576f767f0381d18c2c1

Powered by Google App Engine
This is Rietveld 408576698