Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2697223002: Fix LogDog client queries without state. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Fix LogDog client queries without state. LogDog is allowed to issue queries without retrieving state. However, the client library considered a lack of state an error. Update it to permit this. Update Milo's tests to properly reflect the missing state for its queries so the client library would have properly failed before, and now properly succeeds. BUG=chromium:687625 TEST=unit R=hinoka@chromium.org Review-Url: https://codereview.chromium.org/2697223002 Committed: https://github.com/luci/luci-go/commit/ddca4ffe013b628ca436a6c7a3df7d565ba2e8b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -45 lines) Patch
M logdog/client/coordinator/list.go View 2 chunks +1 line, -6 lines 0 comments Download
M logdog/client/coordinator/query.go View 2 chunks +2 lines, -7 lines 0 comments Download
M logdog/client/coordinator/stream.go View 3 chunks +18 lines, -29 lines 0 comments Download
M milo/appengine/buildbot/buildinfo_test.go View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
3 years, 10 months ago (2017-02-16 01:59:03 UTC) #1
hinoka
lgtm
3 years, 10 months ago (2017-02-16 02:10:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697223002/1
3 years, 10 months ago (2017-02-16 02:11:31 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 02:19:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/ddca4ffe013b628ca436a6c7a3df7d565ba2e8b0

Powered by Google App Engine
This is Rietveld 408576698