Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: logdog/client/coordinator/query.go

Issue 2697223002: Fix LogDog client queries without state. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/coordinator/list.go ('k') | logdog/client/coordinator/stream.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/coordinator/query.go
diff --git a/logdog/client/coordinator/query.go b/logdog/client/coordinator/query.go
index 0901b4144d93fe8bfffd1ca876a7aab2ead78d60..c8899bd6c82d41e95760e1abb6f829fb8021660b 100644
--- a/logdog/client/coordinator/query.go
+++ b/logdog/client/coordinator/query.go
@@ -5,7 +5,6 @@
package coordinator
import (
- "fmt"
"time"
"github.com/luci/luci-go/common/proto/google"
@@ -157,12 +156,8 @@ func (c *Client) Query(ctx context.Context, project cfgtypes.ProjectName, path s
return normalizeError(err)
}
- for i, s := range resp.Streams {
- st, err := loadLogStream(resp.Project, types.StreamPath(s.Path), s.State, s.Desc)
- if err != nil {
- return fmt.Errorf("failed to load stream state #%d: %v", i, err)
- }
-
+ for _, s := range resp.Streams {
+ st := loadLogStream(resp.Project, types.StreamPath(s.Path), s.State, s.Desc)
if !cb(st) {
return nil
}
« no previous file with comments | « logdog/client/coordinator/list.go ('k') | logdog/client/coordinator/stream.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698