Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2697093004: Remove unused param in EventFilter::CreateConditionSets. (Closed)

Created:
3 years, 10 months ago by lazyboy
Modified:
3 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused param in EventFilter::CreateConditionSets. This CL also doesn't generate a matcher id (EventMatcher::next_id_) when we don't need one. BUG=None Test=Should not have any visible effects. Review-Url: https://codereview.chromium.org/2697093004 Cr-Commit-Position: refs/heads/master@{#451030} Committed: https://chromium.googlesource.com/chromium/src/+/306a6a5a991467ce0cc34b56e05af420ecd90919

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M extensions/common/event_filter.h View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/common/event_filter.cc View 2 chunks +2 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
lazyboy
https://codereview.chromium.org/2697093004/diff/1/extensions/common/event_filter.cc File extensions/common/event_filter.cc (left): https://codereview.chromium.org/2697093004/diff/1/extensions/common/event_filter.cc#oldcode88 extensions/common/event_filter.cc:88: MatcherID id, Note: from git log, this was unused ...
3 years, 10 months ago (2017-02-15 23:59:00 UTC) #2
Devlin
nice; lgtm.
3 years, 10 months ago (2017-02-16 01:25:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697093004/1
3 years, 10 months ago (2017-02-16 17:24:28 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 18:54:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/306a6a5a991467ce0cc34b56e05a...

Powered by Google App Engine
This is Rietveld 408576698