Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: extensions/common/event_filter.cc

Issue 2697093004: Remove unused param in EventFilter::CreateConditionSets. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/event_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/event_filter.cc
diff --git a/extensions/common/event_filter.cc b/extensions/common/event_filter.cc
index fa587016ba3480f1a7f9c9c24b54b08d4c898422..b91f25f1e47fd9303b9a506a10028f7772852500 100644
--- a/extensions/common/event_filter.cc
+++ b/extensions/common/event_filter.cc
@@ -57,11 +57,11 @@ EventFilter::~EventFilter() {
EventFilter::MatcherID EventFilter::AddEventMatcher(
const std::string& event_name,
std::unique_ptr<EventMatcher> matcher) {
- MatcherID id = next_id_++;
URLMatcherConditionSet::Vector condition_sets;
- if (!CreateConditionSets(id, matcher.get(), &condition_sets))
+ if (!CreateConditionSets(matcher.get(), &condition_sets))
return -1;
+ MatcherID id = next_id_++;
for (URLMatcherConditionSet::Vector::iterator it = condition_sets.begin();
it != condition_sets.end(); it++) {
condition_set_id_to_event_matcher_id_.insert(
@@ -85,7 +85,6 @@ const std::string& EventFilter::GetEventName(MatcherID id) {
}
bool EventFilter::CreateConditionSets(
- MatcherID id,
lazyboy 2017/02/15 23:59:00 Note: from git log, this was unused since it was i
EventMatcher* matcher,
URLMatcherConditionSet::Vector* condition_sets) {
if (matcher->GetURLFilterCount() == 0) {
« no previous file with comments | « extensions/common/event_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698