Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2697063003: Revert of SkScalarMul is deprecated (Closed)

Created:
3 years, 10 months ago by reed1
Modified:
3 years, 10 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SkScalarMul is deprecated (patchset #2 id:20001 of https://codereview.chromium.org/2693423004/ ) Reason for revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/builds/194212/steps/compile/logs/stdio Original issue's description: > SkScalarMul is deprecated > > BUG= > > Review-Url: https://codereview.chromium.org/2693423004 > Cr-Commit-Position: refs/heads/master@{#451009} > Committed: https://chromium.googlesource.com/chromium/src/+/b9fd03507bd850c6746986dfe021c5cf8e5f7c60 TBR=jochen@chromium.org,fmalita@chromium.org,sadrul@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2697063003 Cr-Commit-Position: refs/heads/master@{#451015} Committed: https://chromium.googlesource.com/chromium/src/+/7b23d4a6d90df4d29fe04165c07da7ff7d655e0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M components/exo/wayland/clients/motion_events.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/harfbuzz_font_skia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
reed1
Created Revert of SkScalarMul is deprecated
3 years, 10 months ago (2017-02-16 17:55:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697063003/1
3 years, 10 months ago (2017-02-16 17:56:30 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 17:57:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b23d4a6d90df4d29fe04165c07d...

Powered by Google App Engine
This is Rietveld 408576698