Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2693423004: SkScalarMul is deprecated (Closed)

Created:
3 years, 10 months ago by reed1
Modified:
3 years, 10 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SkScalarMul is deprecated BUG= Review-Url: https://codereview.chromium.org/2693423004 Cr-Original-Commit-Position: refs/heads/master@{#451009} Committed: https://chromium.googlesource.com/chromium/src/+/b9fd03507bd850c6746986dfe021c5cf8e5f7c60 Review-Url: https://codereview.chromium.org/2693423004 Cr-Commit-Position: refs/heads/master@{#451300} Committed: https://chromium.googlesource.com/chromium/src/+/769ab95c120512f2a02cba01a805cce00d651859

Patch Set 1 #

Patch Set 2 : rm guard for imagegenerator #

Patch Set 3 : undo the ImageGenerator flag change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M components/exo/wayland/clients/motion_events.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/harfbuzz_font_skia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
reed1
need OWNERS for minor refactoring CL
3 years, 10 months ago (2017-02-16 03:53:57 UTC) #6
f(malita)
skia/ lgtm
3 years, 10 months ago (2017-02-16 14:07:21 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-16 14:47:24 UTC) #10
sky
LGTM
3 years, 10 months ago (2017-02-16 17:30:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693423004/20001
3 years, 10 months ago (2017-02-16 17:32:58 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b9fd03507bd850c6746986dfe021c5cf8e5f7c60
3 years, 10 months ago (2017-02-16 17:46:06 UTC) #16
reed1
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2697063003/ by reed@google.com. ...
3 years, 10 months ago (2017-02-16 17:55:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693423004/40001
3 years, 10 months ago (2017-02-16 21:22:40 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120986)
3 years, 10 months ago (2017-02-16 23:35:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693423004/40001
3 years, 10 months ago (2017-02-17 12:17:52 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 14:17:58 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/769ab95c120512f2a02cba01a805...

Powered by Google App Engine
This is Rietveld 408576698