Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(42)

Issue 2697013004: Reland Mus Demo: Move definition of WindowTreeData into separate files (Closed)

Created:
10 months ago by fwang
Modified:
10 months ago
Reviewers:
kylechar
CC:
chromium-reviews, rjkroege, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Mus Demo: Move definition of WindowTreeData into separate files Reason for revert: Unfortunate final s/int/unsigned/ causing Windows build errors [1]. Relanding it without that final change. Original issue's description: > Mus Demo: Move definition of WindowTreeData into mus_demo.h > > In follow-up CLs, MusDemo will be split into two derived classes > demonstrating external and internal modes. These classes will handle > instances of WindowTreeData and for that purpose this CL moves the > definition of WindowTreeData into separate files. We also adjust a bit > the Constructor/Init to help in future CLs. [1] https://codereview.chromium.org/2694843005/#msg31 BUG=666958 R=kylechar@chromium.org Review-Url: https://codereview.chromium.org/2697013004 Cr-Commit-Position: refs/heads/master@{#450945} Committed: https://chromium.googlesource.com/chromium/src/+/600a1b10bce210bcd850268024a2413a0ee0d0fa

Patch Set 1 #

Messages

Total messages: 11 (7 generated)
fwang
PTAL
10 months ago (2017-02-16 06:21:47 UTC) #2
kylechar
lgtm.
10 months ago (2017-02-16 13:35:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697013004/1
10 months ago (2017-02-16 13:36:39 UTC) #8
commit-bot: I haz the power
10 months ago (2017-02-16 13:41:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/600a1b10bce210bcd850268024a2...

Powered by Google App Engine
This is Rietveld 0eb02b776