Fix incorrect tests for storage APIs in data: URL workers

Fix incorrect tests for storage APIs in data: URL workers

Removed localStorage test as localStorage is never exposed to workers.

IndexedDB spec will be updated to throw when used from opaque origins.
(https://github.com/w3c/IndexedDB/pull/150)

Added a new test for webdatabase.

BUG=270979
Review-Url: https://codereview.chromium.org/2697003002
Cr-Commit-Position: refs/heads/master@{#450654}
Committed: https://chromium.googlesource.com/chromium/src/+/a97d64509b72ffc3f69ab86d57b2d45536a8b60f

[andypaicu2, 2017-02-15 08:40:59]

andypaicu@google.com changed reviewers:
+ jochen@chromium.org, mek@chromium.org, mkwst@chromium.org

[jochen (gone - plz use gerrit), 2017-02-15 08:50:41]

A better CL description would be more self-contained e.g.

`Fix incorrect test for storage APIs in workers created from data: URLs

Previously, we tested for the availability of storage and indexeddb APIs.
Storage,
however, is never exposed to workers, and indexeddb's spec doesn't disallow
access
from opaque origins.

Update the test to probe for web database instead of local storage. The
indexeddb
spec will be updated to throw when used from opaque origins
(https://github.com/w3c/IndexedDB/pull/150)

BUG=270979`

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
(right):

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html:32:
assert_worker_throws('websql inaccessible', 'self.openDatabase("someDBName",
"1.0", "someDBName", 1);');
the official name is WebDatabase

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html (right):

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html:45:
assert_worker_throws('indexedDB inaccessible',
'self.indexedDB.open("someDBName")');
once https://github.com/w3c/IndexedDB/pull/150 lands, this is actually spec
conforming :)

[jochen (gone - plz use gerrit), 2017-02-15 08:50:57]

lgtm with better CL description & updated comment

[andypaicu2, 2017-02-15 08:58:39]

Description was changed from

==========
Continuation of code review 2685543002. Addressing issues with tests.

Removed useless localstorage test. Added websql test.

BUG=270979
==========

to

==========
Removed localStorage test as localStorage is never exposed to workers.

IndexedDB spec will be updated to throw when used from opaque origins.
(https://github.com/w3c/IndexedDB/pull/150)

Added a new test for webdatabase.

BUG=270979
==========

[andypaicu2, 2017-02-15 08:58:55]

Description was changed from

==========
Removed localStorage test as localStorage is never exposed to workers.

IndexedDB spec will be updated to throw when used from opaque origins.
(https://github.com/w3c/IndexedDB/pull/150)

Added a new test for webdatabase.

BUG=270979
==========

to

==========
Fix incorrect tests for storage APIs in data: URL workers

Removed localStorage test as localStorage is never exposed to workers.

IndexedDB spec will be updated to throw when used from opaque origins.
(https://github.com/w3c/IndexedDB/pull/150)

Added a new test for webdatabase.

BUG=270979
==========

[andypaicu2, 2017-02-15 09:10:40]

On 2017/02/15 at 08:50:41, jochen wrote:
> A better CL description would be more self-contained e.g.
> 
> `Fix incorrect test for storage APIs in workers created from data: URLs
> 
> Previously, we tested for the availability of storage and indexeddb APIs.
Storage,
> however, is never exposed to workers, and indexeddb's spec doesn't disallow
access
> from opaque origins.
> 
> Update the test to probe for web database instead of local storage. The
indexeddb
> spec will be updated to throw when used from opaque origins
(https://github.com/w3c/IndexedDB/pull/150)
> 
> BUG=270979`
> 
>
https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
(right):
> 
>
https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html:32:
assert_worker_throws('websql inaccessible', 'self.openDatabase("someDBName",
"1.0", "someDBName", 1);');
> the official name is WebDatabase
> 
>
https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html
(right):
> 
>
https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html:45:
assert_worker_throws('indexedDB inaccessible',
'self.indexedDB.open("someDBName")');
> once https://github.com/w3c/IndexedDB/pull/150 lands, this is actually spec
conforming :)

Improved (hopefully) the CL description and title

[andypaicu2, 2017-02-15 09:10:54]

Made code review changes

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
(right):

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html:32:
assert_worker_throws('websql inaccessible', 'self.openDatabase("someDBName",
"1.0", "someDBName", 1);');
On 2017/02/15 at 08:50:41, jochen wrote:
> the official name is WebDatabase

Changed name to the title in the specs: Web SQL Database

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html (right):

https://codereview.chromium.org/2697003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html:45:
assert_worker_throws('indexedDB inaccessible',
'self.indexedDB.open("someDBName")');
On 2017/02/15 at 08:50:41, jochen wrote:
> once https://github.com/w3c/IndexedDB/pull/150 lands, this is actually spec
conforming :)

Added a comment on this test

[jochen (gone - plz use gerrit), 2017-02-15 09:16:22]

lgtm

[andypaicu2, 2017-02-15 09:20:15]

The CQ bit was checked by andypaicu@google.com

[commit-bot: I haz the power, 2017-02-15 09:20:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 10:34:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487150415700080,
"parent_rev": "4e8c7f7ffd6c04613921e419bd23afd3ef9a35c1", "commit_rev":
"a97d64509b72ffc3f69ab86d57b2d45536a8b60f"}

[commit-bot: I haz the power, 2017-02-15 10:35:24]

Description was changed from

==========
Fix incorrect tests for storage APIs in data: URL workers

Removed localStorage test as localStorage is never exposed to workers.

IndexedDB spec will be updated to throw when used from opaque origins.
(https://github.com/w3c/IndexedDB/pull/150)

Added a new test for webdatabase.

BUG=270979
==========

to

==========
Fix incorrect tests for storage APIs in data: URL workers

Removed localStorage test as localStorage is never exposed to workers.

IndexedDB spec will be updated to throw when used from opaque origins.
(https://github.com/w3c/IndexedDB/pull/150)

Added a new test for webdatabase.

BUG=270979

Review-Url: https://codereview.chromium.org/2697003002
Cr-Commit-Position: refs/heads/master@{#450654}
Committed:
https://chromium.googlesource.com/chromium/src/+/a97d64509b72ffc3f69ab86d57b2...
==========

[commit-bot: I haz the power, 2017-02-15 10:35:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a97d64509b72ffc3f69ab86d57b2...