Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html

Issue 2697003002: Fix incorrect tests for storage APIs in data: URL workers (Closed)
Patch Set: Added comment for the indexedDB test. Improved Web Sql Database test name. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html b/third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
index 05d3b5138b99d7949d04b088ef42b61e741d89d4..395058454d09a5d6ccfe6afc715bd0fb9dee32dc 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/workers/data-url-shared.html
@@ -26,11 +26,13 @@ assert_worker_sends_pass('empty MIME allowed', '', 'port.postMessage("PASS")');
// Communications goes both ways
assert_worker_sends_pass('communication goes both ways', 'application/javascript', 'port.onmessage = function(e) { port.postMessage("PASS"); }');
-// 'data:' workers are cross-origin
+// test access to storage APIs
+// once https://github.com/w3c/IndexedDB/pull/150 lands, this is spec conforming
assert_worker_throws('indexedDB inaccessible', 'self.indexedDB.open("someDBName")');
-assert_worker_throws('localStorage inaccessible', 'self.localStorage.testItem');
-assert_worker_sends_pass('cross-origin worker', '', 'fetch("/").then(() => port.postMessage("FAIL"), () => port.postMessage("PASS"))');
+assert_worker_throws('Web SQL Database inaccessible', 'self.openDatabase("someDBName", "1.0", "someDBName", 1);');
+// 'data:' workers are cross-origin
+assert_worker_sends_pass('cross-origin worker', '', 'fetch("/").then(() => port.postMessage("FAIL"), () => port.postMessage("PASS"))');
// 'data:' workers have opaque origin
assert_worker_sends_pass('worker has opaque origin', 'application/javascript', 'if (self.location.origin == "null") port.postMessage("PASS"); else port.postMessage("FAIL");');
</script>
« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/workers/data-url.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698