Chromium Code Reviews
DescriptionRevert of Remove include_rules entries for WebString (patchset #1 id:1 of https://codereview.chromium.org/2696013005/ )
Reason for revert:
Breaks checkdeps, content/common/DEPS
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_messages.h
Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h"
Because of "-third_party/WebKit" from content/common's include_rules.
ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_owner_properties.h
Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h"
Because of "-third_party/WebKit" from content/common's include_rules.
FAILED
Original issue's description:
> Remove include_rules entries for WebString
>
> These all reference WebString, so shouldn't be included. There
> might be more, but since we don't link against WebString.cpp
> any more it should be relatively safe anyway.
>
> BUG=248653
>
> Review-Url: https://codereview.chromium.org/2696013005
> Cr-Commit-Position: refs/heads/master@{#450539}
> Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e986a5a432a93ca
TBR=jam@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=248653
Review-Url: https://codereview.chromium.org/2696973003
Cr-Commit-Position: refs/heads/master@{#450629}
Committed: https://chromium.googlesource.com/chromium/src/+/acc4db2a8ba1eb5067653b674006b096b2712c1d
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||