Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Issue 2696973003: Revert of Remove include_rules entries for WebString (Closed)

Created:
3 years, 10 months ago by perkj_chrome
Modified:
3 years, 10 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove include_rules entries for WebString (patchset #1 id:1 of https://codereview.chromium.org/2696013005/ ) Reason for revert: Breaks checkdeps, content/common/DEPS https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_messages.h Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h" Because of "-third_party/WebKit" from content/common's include_rules. ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_owner_properties.h Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h" Because of "-third_party/WebKit" from content/common's include_rules. FAILED Original issue's description: > Remove include_rules entries for WebString > > These all reference WebString, so shouldn't be included. There > might be more, but since we don't link against WebString.cpp > any more it should be relatively safe anyway. > > BUG=248653 > > Review-Url: https://codereview.chromium.org/2696013005 > Cr-Commit-Position: refs/heads/master@{#450539} > Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e986a5a432a93ca TBR=jam@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=248653 Review-Url: https://codereview.chromium.org/2696973003 Cr-Commit-Position: refs/heads/master@{#450629} Committed: https://chromium.googlesource.com/chromium/src/+/acc4db2a8ba1eb5067653b674006b096b2712c1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/DEPS View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
perkj_chrome
Created Revert of Remove include_rules entries for WebString
3 years, 10 months ago (2017-02-15 07:44:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696973003/1
3 years, 10 months ago (2017-02-15 07:44:32 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 07:45:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/acc4db2a8ba1eb5067653b674006...

Powered by Google App Engine
This is Rietveld 408576698