Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2696013005:
Remove include_rules entries for WebString (Closed)
DescriptionRemove include_rules entries for WebString
These all reference WebString, so shouldn't be included. There
might be more, but since we don't link against WebString.cpp
any more it should be relatively safe anyway.
BUG=248653
Review-Url: https://codereview.chromium.org/2696013005
Cr-Original-Commit-Position: refs/heads/master@{#450539}
Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e986a5a432a93ca
Review-Url: https://codereview.chromium.org/2696013005
Cr-Commit-Position: refs/heads/master@{#450788}
Committed: https://chromium.googlesource.com/chromium/src/+/dc76b47f5c8987551d2795fc2b47d0316f04dda0
Patch Set 1 #
Total comments: 1
Patch Set 2 : don't disallow WebFrameOwnerProperties for ScrollingMode #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== Remove include_rules entries for WebString BUG=248653 ========== to ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 ==========
scottmg@chromium.org changed reviewers: + jam@chromium.org
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487118670995110, "parent_rev":
"2884d9bee4a26233c3195f8d05b68aae8277e5c8", "commit_rev":
"40a8bc08d3b3e3de81820bfb4e986a5a432a93ca"}
Message was sent while issue was closed.
Description was changed from ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 ========== to ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 Review-Url: https://codereview.chromium.org/2696013005 Cr-Commit-Position: refs/heads/master@{#450539} Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98...
Message was sent while issue was closed.
On 2017/02/15 01:22:20, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98... Breaks checkdeps, content/common/DEPS https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_messages.h Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h" Because of "-third_party/WebKit" from content/common's include_rules. ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_owner_properties.h Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h" Because of "-third_party/WebKit" from content/common's include_rules. FAILED
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2696973003/ by perkj@chromium.org. The reason for reverting is: Breaks checkdeps, content/common/DEPS https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_messages.h Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h" Because of "-third_party/WebKit" from content/common's include_rules. ERROR in /mnt/data/b/c/b/Linux_Tests/src/content/common/frame_owner_properties.h Illegal include: "third_party/WebKit/public/web/WebFrameOwnerProperties.h" Because of "-third_party/WebKit" from content/common's include_rules. FAILED.
Message was sent while issue was closed.
https://codereview.chromium.org/2696013005/diff/1/content/common/DEPS File content/common/DEPS (left): https://codereview.chromium.org/2696013005/diff/1/content/common/DEPS#oldcode68 content/common/DEPS:68: "+third_party/WebKit/public/web/WebFrameOwnerProperties.h", The struct in this header can't be used, but there's also an enum (ScrollingMode) in that struct used by FrameOwnerProperties. It's not great, but I guess I'll reland without this line. (I manually checked this works, since analyze is causing the trybots not to check this properly.)
Message was sent while issue was closed.
Description was changed from ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 Review-Url: https://codereview.chromium.org/2696013005 Cr-Commit-Position: refs/heads/master@{#450539} Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98... ========== to ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 Review-Url: https://codereview.chromium.org/2696013005 Cr-Commit-Position: refs/heads/master@{#450539} Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98... ==========
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org Link to the patchset: https://codereview.chromium.org/2696013005/#ps20001 (title: "don't disallow WebFrameOwnerProperties for ScrollingMode")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487186417485860,
"parent_rev": "5cfa87ff259fb01681ec6f509f1bad1d0702fa75", "commit_rev":
"dc76b47f5c8987551d2795fc2b47d0316f04dda0"}
Message was sent while issue was closed.
Description was changed from ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 Review-Url: https://codereview.chromium.org/2696013005 Cr-Commit-Position: refs/heads/master@{#450539} Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98... ========== to ========== Remove include_rules entries for WebString These all reference WebString, so shouldn't be included. There might be more, but since we don't link against WebString.cpp any more it should be relatively safe anyway. BUG=248653 Review-Url: https://codereview.chromium.org/2696013005 Cr-Original-Commit-Position: refs/heads/master@{#450539} Committed: https://chromium.googlesource.com/chromium/src/+/40a8bc08d3b3e3de81820bfb4e98... Review-Url: https://codereview.chromium.org/2696013005 Cr-Commit-Position: refs/heads/master@{#450788} Committed: https://chromium.googlesource.com/chromium/src/+/dc76b47f5c8987551d2795fc2b47... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/dc76b47f5c8987551d2795fc2b47... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
