Don't build chrome://settings on Android

Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG=673825, 693619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2696763003
Cr-Commit-Position: refs/heads/master@{#451398}
Committed: https://chromium.googlesource.com/chromium/src/+/fb1a92c477c4dc2f72fdbeaa28b09b632cd928da

[agrieve, 2017-02-14 15:31:13]

Description was changed from

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place
==========

to

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[agrieve, 2017-02-14 15:41:09]

agrieve@chromium.org changed reviewers:
+ dbeam@chromium.org

[agrieve, 2017-02-14 15:41:09]

📕

[Dan Beam, 2017-02-14 19:46:06]

💮 lgtm 💮

[agrieve, 2017-02-14 19:48:25]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-02-14 19:48:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 19:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 19:54:58]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2017-02-14 20:12:31]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 20:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 21:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:27:22]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-02-15 16:40:12]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-02-15 16:40:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2696763003/#ps20001
(title: "fix gn gen")

[commit-bot: I haz the power, 2017-02-15 16:40:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 16:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 16:49:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[agrieve, 2017-02-15 18:34:36]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-02-15 18:36:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 19:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 19:19:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2017-02-17 19:24:47]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-17 19:25:45]

Description was changed from

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-02-17 19:26:15]

turns out we need this to optimize chrome://md-settings (we landed a CL to try
to do this but it broke the android compile, we believe this might fix)

[commit-bot: I haz the power, 2017-02-17 20:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:38:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-02-17 20:54:07]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 20:54:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-17 21:04:22]

On 2017/02/17 19:26:15, Dan Beam wrote:
> turns out we need this to optimize chrome://md-settings (we landed a CL to try
> to do this but it broke the android compile, we believe this might fix)

[kinda] verified locally that this change fixes the compilation issue we hit
last night

[Dan Beam, 2017-02-17 21:08:35]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-02-17 21:08:41]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-02-17 21:08:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2696763003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-17 21:09:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-17 21:50:58]

Description was changed from

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG=673825,693619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-02-17 23:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:14:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Dan Beam, 2017-02-17 23:18:28]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:20:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:38:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487373508790910,
"parent_rev": "59e6fc09543e4cb2aa20e1869130a51bff279bae", "commit_rev":
"fb1a92c477c4dc2f72fdbeaa28b09b632cd928da"}

[commit-bot: I haz the power, 2017-02-17 23:39:01]

Description was changed from

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG=673825,693619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't build chrome://settings on Android

It already wasn't being included via repack(), so this just stops it
from being built in the first place

BUG=673825,693619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2696763003
Cr-Commit-Position: refs/heads/master@{#451398}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb1a92c477c4dc2f72fdbeaa28b0...
==========

[commit-bot: I haz the power, 2017-02-17 23:39:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fb1a92c477c4dc2f72fdbeaa28b0...