Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4225)

Unified Diff: chrome/BUILD.gn

Issue 2696763003: Don't build chrome://settings on Android (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 1a2185f32fc43da1ebe3c7f0cd02afacb5ad1fb2..ac76027c66505930ffaaf7925e01ea9d26930725 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1344,20 +1344,26 @@ group("resources") {
}
group("extra_resources") {
+ # Deps should be same as those in chrome_extra_paks() within chrome_paks.gni.
public_deps = [
- "//chrome/browser/resources:component_extension_resources",
"//chrome/browser/resources:invalidations_resources",
"//chrome/browser/resources:net_internals_resources",
- "//chrome/browser/resources:options_resources",
"//chrome/browser/resources:password_manager_internals_resources",
"//chrome/browser/resources:policy_resources",
"//chrome/browser/resources:quota_internals_resources",
- "//chrome/browser/resources:settings_resources",
"//chrome/browser/resources:task_scheduler_internals_resources",
"//chrome/browser/resources:translate_internals_resources",
"//chrome/browser/resources:webapks_ui_resources",
]
+ if (!is_android && !is_ios) {
+ public_deps += [
+ "//chrome/browser/resources:component_extension_resources",
+ "//chrome/browser/resources:options_resources",
+ "//chrome/browser/resources:settings_resources",
+ ]
+ }
+
if (is_chromeos) {
public_deps += [ "//chrome/browser/resources/chromeos/chromevox" ]
public_deps += [ "//chrome/browser/resources/chromeos/select_to_speak" ]
@@ -1432,14 +1438,16 @@ chrome_paks("packed_resources") {
repack("browser_tests_pak") {
sources = [
- "$root_gen_dir/chrome/options_test_resources.pak",
"$root_gen_dir/chrome/webui_test_resources.pak",
]
output = "$root_out_dir/browser_tests.pak"
deps = [
- "//chrome/browser/resources:options_test_resources",
"//chrome/test/data:webui_test_resources",
]
+ if (!is_android && !is_ios) {
+ sources += [ "$root_gen_dir/chrome/options_test_resources.pak" ]
+ deps += [ "//chrome/browser/resources:options_test_resources" ]
+ }
}
group("strings") {
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698