third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html - Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act…

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act… (Closed)

Patch Set: Change the tests to be testharness-based for the merging into web-platform-tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html b/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

index 44035a2ebf3a6afcc16dc932c7f1b5a2bb6b7c9c..1dae87a8af8cfe781df283f84fefda6188c80b4e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

@@ -1,5 +1,7 @@

<html>

<head>

+<script src="/resources/testharness.js"></script>

+<script src="/resources/testharnessreport.js"></script>

if (window.testRunner) {

domenic 2017/02/21 18:37:43 Probably all this window.testRunner stuff should g

Bin Lu 2017/02/22 05:23:43 Done for the case of disallowing it given no gestu

testRunner.dumpAsText();

@@ -8,17 +10,16 @@ if (window.testRunner) {

testRunner.waitUntilDone();

}

-window.addEventListener("message", e => {

- if (e.data == "PASS")

- testRunner.notifyDone();

- else

- testRunner.testFailed("'top.location' didn't throw.");

-});

+test(function() {

domenic 2017/02/21 18:37:43 I think this should be async_test. Then line 14 sh

Bin Lu 2017/02/22 05:23:44 Done. Thanks for the pointer!

+ window.addEventListener("message", e => {

+ assert_equals(e.data, "PASS", "The message says 'PASS' instead of 'FAIL'");

+ });

+}, "The sandboxed iframe posted a message saying the test was in the state of 'PASS'.");

</script>

</head>

<body>

- <p>This tests that an iframe in sandbox with 'allow-top-navigation-with-user-activation'

+ <p>This tests that an iframe in sandbox with 'allow-top-navigation-by-user-activation'

cannot navigate its top level page, if it is not trigged by a user gesture.</p>

- <iframe sandbox='allow-top-navigation-with-user-activation allow-scripts' src="http://localhost:8000/security/frameNavigation/resources/iframe-that-performs-top-navigation-without-user-gesture-failed.html"></iframe>

+ <iframe sandbox='allow-top-navigation-by-user-activation allow-scripts' src="resources/iframe-that-performs-top-navigation-without-user-gesture-failed.html"></iframe>

</body>

</html>