Move media permission checking logic for ChromeOS login pages

chrome/browser/chromeos/login/ui/webui_login_view.h

Index: chrome/browser/chromeos/login/ui/webui_login_view.h
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.h b/chrome/browser/chromeos/login/ui/webui_login_view.h
index 9c306363697b39b595282badbeb74f4d6cf969f0..8c13478d42f40de26776fb68c55def6f6825896e 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.h
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.h
@@ -56,6 +56,9 @@ class WebUILoginView : public views::View,
   // Internal class name.
   static const char kViewClassName[];
 
+  // Returns true if the given WebContentsDelegate is a WebUILoginView.
+  static bool IsWebUILoginView(const content::WebContentsDelegate* delegate);

[achuithb, 2017/02/16 09:05:38]

Let's not do this here.

You can get WebUILoginView webcontents by calling:
LoginDisplayHost::default_host()->GetWebUILoginView()->GetWebContents();

For eg.
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/screens/er...

If you want to keep this method (I would prefer not), you could add it in
login/helper.cc:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/helper.cc?...

The implementation should look like:
bool IsWebUILoginView(const content::WebContents* web_contents) {
  return GetLoginWebContents() == web_contents;
}

But you're only using this in one place so I think you can just inline this
logic in media_permission.cc

[raymes, 2017/02/16 10:36:14]

I see - so there is only ever one of these around? That would make sense.

[achuithb, 2017/02/16 10:38:49]

Yup, there's only one 

[raymes, 2017/02/21 01:29:55]

Done.

[raymes, 2017/02/21 01:29:55]

Done.

+
   explicit WebUILoginView(const WebViewSettings& settings);
   ~WebUILoginView() override;