Move media permission checking logic for ChromeOS login pages

chrome/browser/chromeos/login/ui/webui_login_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_UI_WEBUI_LOGIN_VIEW_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_UI_WEBUI_LOGIN_VIEW_H_
 
 #include <map>
 #include <string>
 
@@ skipping 38 matching lines @@
     bool check_for_preload = false;
 
     // Title of the web contents. This will be shown in the task manager. If
     // empty, the default webview title will be used.
     base::string16 web_view_title;
   };
 
   // Internal class name.
   static const char kViewClassName[];
 
+  // Returns true if the given WebContentsDelegate is a WebUILoginView.
+  static bool IsWebUILoginView(const content::WebContentsDelegate* delegate);

[achuithb, 2017/02/16 09:05:38]

Let's not do this here.

You can get WebUILoginView webcontents by calling:
LoginDisplayHost::default_host()->GetWebUILoginView()->GetWebContents();

For eg.
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/screens/er...

If you want to keep this method (I would prefer not), you could add it in
login/helper.cc:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/helper.cc?...

The implementation should look like:
bool IsWebUILoginView(const content::WebContents* web_contents) {
  return GetLoginWebContents() == web_contents;
}

But you're only using this in one place so I think you can just inline this
logic in media_permission.cc

[raymes, 2017/02/16 10:36:14]

I see - so there is only ever one of these around? That would make sense.

[achuithb, 2017/02/16 10:38:49]

Yup, there's only one 

[raymes, 2017/02/21 01:29:55]

Done.

[raymes, 2017/02/21 01:29:55]

Done.

+
   explicit WebUILoginView(const WebViewSettings& settings);
   ~WebUILoginView() override;
 
   // Initializes the webui login view.
   virtual void Init();
 
   // Overridden from views::View:
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
   const char* GetClassName() const override;
   void RequestFocus() override;
@@ skipping 131 matching lines @@
   std::unique_ptr<CycleFocusTraversable> cycle_focus_traversable_;
 
   base::ObserverList<web_modal::ModalDialogHostObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(WebUILoginView);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_UI_WEBUI_LOGIN_VIEW_H_