Move media permission checking logic for ChromeOS login pages

chrome/browser/media/webrtc/media_permission.h

Index: chrome/browser/media/webrtc/media_permission.h
diff --git a/chrome/browser/media/webrtc/media_permission.h b/chrome/browser/media/webrtc/media_permission.h
index 708ae39877ac20dd05e61dd105158de7514164ba..76fb5c7b94a1261436dd3a89d363ea749bdb3708 100644
--- a/chrome/browser/media/webrtc/media_permission.h
+++ b/chrome/browser/media/webrtc/media_permission.h
@@ -15,13 +15,18 @@
 
 class Profile;
 
+namespace content {
+class WebContents;
+}  // namespace content

[achuithb, 2017/02/16 09:05:38]

drop comment

[Sergey Ulanov, 2017/02/16 19:26:17]

Why? It's required by style guide.

[achuithb, 2017/02/16 20:02:12]

We drop it for short namespaces since the namespace that the closing brace
belongs to is obvious, and it adds unnecessary clutter.

[raymes, 2017/02/21 01:29:55]

I've seen both and I don't feel strongly. I've removed it for now though
generally I think it's better to stick to the style guide when it's provided.

+
 // Represents a permission for microphone/camera access.
 class MediaPermission {
  public:
   MediaPermission(ContentSettingsType content_type,
                   const GURL& requesting_origin,
                   const GURL& embedding_origin,
-                  Profile* profile);
+                  Profile* profile,
+                  content::WebContents* web_contents);
 
   // Returns the status of the permission. If the setting is
   // CONTENT_SETTING_BLOCK, |denial_reason| will output the reason for it being
@@ -43,6 +48,7 @@ class MediaPermission {
   const GURL embedding_origin_;
   const std::string device_id_;
   Profile* const profile_;
+  content::WebContents* web_contents_;

[achuithb, 2017/02/16 09:05:38]

nit const:
content::WebContents* const web_contents_;

[raymes, 2017/02/21 01:29:55]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(MediaPermission);
 };