Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2696693002: [Mac hermetic] Add iPhoneOS subset to mac hermetic toolchain. (Closed)

Created:
3 years, 10 months ago by justincohen
Modified:
3 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac hermetic] Add iPhoneOS subset to mac hermetic toolchain. Apparently `xcrun -sdk macosx10.12 --show-sdk-path` needs the iPhoneOS platform as well. BUG=669240 Review-Url: https://codereview.chromium.org/2696693002 Cr-Commit-Position: refs/heads/master@{#450077} Committed: https://chromium.googlesource.com/chromium/src/+/ccbbfa2f4c2f0c8f5736d05a2f9886700d79e738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M build/package_mac_toolchain.py View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
justincohen
sadness, ptal. I've already uploaded this as 8C1002-3 for testing.
3 years, 10 months ago (2017-02-13 20:12:02 UTC) #2
justincohen
ptal
3 years, 10 months ago (2017-02-13 20:23:17 UTC) #5
erikchen
On 2017/02/13 20:23:17, justincohen wrote: > ptal lgtm
3 years, 10 months ago (2017-02-13 20:30:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696693002/1
3 years, 10 months ago (2017-02-13 20:41:39 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 20:52:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccbbfa2f4c2f0c8f5736d05a2f98...

Powered by Google App Engine
This is Rietveld 408576698