Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2696353003: Clean up the Mac shortcut tables, and make them clang-format proof. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up the Mac shortcut tables, and make them clang-format proof. BUG=none TEST=none Review-Url: https://codereview.chromium.org/2696353003 Cr-Commit-Position: refs/heads/master@{#451153} Committed: https://chromium.googlesource.com/chromium/src/+/cbab2928a12119e08c278656de62a310d97a111d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -47 lines) Patch
M chrome/browser/global_keyboard_shortcuts_cocoa_mac.mm View 1 chunk +50 lines, -41 lines 0 comments Download
M chrome/browser/global_keyboard_shortcuts_views_mac.mm View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
When I added those headers in https://codereview.chromium.org/5243003 everything was lined up oh so pretty. clang ...
3 years, 10 months ago (2017-02-16 23:19:29 UTC) #6
Robert Sesek
LGTM, thanks. clang-format would indeed mangle these poorly.
3 years, 10 months ago (2017-02-16 23:23:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696353003/1
3 years, 10 months ago (2017-02-16 23:25:56 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 00:18:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbab2928a12119e08c278656de62...

Powered by Google App Engine
This is Rietveld 408576698