Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: chrome/browser/global_keyboard_shortcuts_views_mac.mm

Issue 2696353003: Clean up the Mac shortcut tables, and make them clang-format proof. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_cocoa_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/global_keyboard_shortcuts_views_mac.mm
diff --git a/chrome/browser/global_keyboard_shortcuts_views_mac.mm b/chrome/browser/global_keyboard_shortcuts_views_mac.mm
index 663b02f98b65649e3957b155805095b349002158..0303ba5dbab832b7c90b61ead9ea57c05b172fdc 100644
--- a/chrome/browser/global_keyboard_shortcuts_views_mac.mm
+++ b/chrome/browser/global_keyboard_shortcuts_views_mac.mm
@@ -10,14 +10,16 @@
// (crbug.com/25946).
const std::vector<KeyboardShortcutData>& GetWindowKeyboardShortcutTable() {
+ // clang-format off
CR_DEFINE_STATIC_LOCAL(std::vector<KeyboardShortcutData>, result, ({
- // cmd shift cntrl option
- // --- ----- ----- ------
- // '{' / '}' characters should be matched earlier than virtual key code
- // (therefore we can match alt-8 as '{' on german keyboards).
- {true, false, false, false, 0, '}', IDC_SELECT_NEXT_TAB},
- {true, false, false, false, 0, '{', IDC_SELECT_PREVIOUS_TAB},
+ //cmd shift cntrl option vkeycode char command
+ //--- ----- ----- ------ -------- ---- -------
+ // '{' / '}' characters should be matched earlier than virtual key codes
+ // (so we can match alt-8 as '{' on German keyboards).
+ {true, false, false, false, 0, '}', IDC_SELECT_NEXT_TAB},
+ {true, false, false, false, 0, '{', IDC_SELECT_PREVIOUS_TAB},
}));
+ // clang-format on
return result;
}
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_cocoa_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698