Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton (Closed)
Patch Set: Fix unit tests to use a ViewsDelegate to guard against crashes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc
diff --git a/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc b/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc
index d14182f96a2b9f22cd2e45fe30b5bca1f9f205f0..db91c5eab9b526e822d39ab4e834a63d41bfc997 100644
--- a/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc
+++ b/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc
@@ -3,8 +3,10 @@
// found in the LICENSE file.
#include <stdint.h>
+#include <memory>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock.h"
@@ -13,6 +15,7 @@
#include "components/storage_monitor/storage_info.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/views/controls/button/checkbox.h"
+#include "ui/views/test/test_views_delegate.h"
using ::testing::_;
using ::testing::AnyNumber;
@@ -41,6 +44,7 @@ class MediaGalleriesDialogTest : public testing::Test {
~MediaGalleriesDialogTest() override {}
void SetUp() override {
std::vector<base::string16> headers;
+ views_delegate_ = base::MakeUnique<views::TestViewsDelegate>();
headers.push_back(base::string16());
headers.push_back(base::ASCIIToUTF16("header2"));
ON_CALL(controller_, GetSectionHeaders()).
@@ -60,6 +64,7 @@ class MediaGalleriesDialogTest : public testing::Test {
private:
// TODO(gbillock): Get rid of this mock; make something specialized.
NiceMock<MediaGalleriesDialogControllerMock> controller_;
+ std::unique_ptr<views::TestViewsDelegate> views_delegate_;
DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogTest);
};

Powered by Google App Engine
This is Rietveld 408576698