chrome/test/base/chrome_render_view_host_test_harness.h - Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/chrome_render_view_host_test_harness.h

Issue 2696263002: Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton (Closed)

Patch Set: Fix unit tests to use a ViewsDelegate to guard against crashes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/chrome_render_view_host_test_harness.h

diff --git a/chrome/test/base/chrome_render_view_host_test_harness.h b/chrome/test/base/chrome_render_view_host_test_harness.h

index 5108692faf1796a8098ba965d68f34ee75281f9f..acdd4683b0f4bf8945cb091e41d46137a72306c1 100644

--- a/chrome/test/base/chrome_render_view_host_test_harness.h

+++ b/chrome/test/base/chrome_render_view_host_test_harness.h

@@ -5,8 +5,11 @@

#ifndef CHROME_TEST_BASE_CHROME_RENDER_VIEW_HOST_TEST_HARNESS_H_

#define CHROME_TEST_BASE_CHROME_RENDER_VIEW_HOST_TEST_HARNESS_H_

+#include <memory>

#include "base/compiler_specific.h"

#include "content/public/test/test_renderer_host.h"

+#include "ui/views/test/test_views_delegate.h"

class TestingProfile;

@@ -26,6 +29,9 @@ class ChromeRenderViewHostTestHarness

// content::RenderViewHostTestHarness.

content::BrowserContext* CreateBrowserContext() override;

+ private:

+ std::unique_ptr<views::TestViewsDelegate> views_delegate_;

Peter Kasting 2017/02/28 02:44:04 Yeah, pretty sure this can't be here, as RVH tests

};

#endif // CHROME_TEST_BASE_CHROME_RENDER_VIEW_HOST_TEST_HARNESS_H_