Refactor ViewsDelegate and MD-ify the icon-to-text spacing for checkbox and radiobutton

chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
+#include <memory>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock.h"
 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h"
 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h"
 #include "components/storage_monitor/storage_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/views/controls/button/checkbox.h"
+#include "ui/views/test/test_views_delegate.h"
 
 using ::testing::_;
 using ::testing::AnyNumber;
 using ::testing::Mock;
 using ::testing::NiceMock;
 using ::testing::Return;
 using ::testing::ReturnPointee;
 
 namespace {
 
 MediaGalleryPrefInfo MakePrefInfoForTesting(MediaGalleryPrefId id) {
   MediaGalleryPrefInfo gallery;
   gallery.pref_id = id;
   gallery.device_id = storage_monitor::StorageInfo::MakeDeviceId(
       storage_monitor::StorageInfo::FIXED_MASS_STORAGE,
       base::Uint64ToString(id));
   gallery.display_name = base::ASCIIToUTF16("Display Name");
   return gallery;
 }
 
 }  // namespace
 
 class MediaGalleriesDialogTest : public testing::Test {
  public:
   MediaGalleriesDialogTest() {}
   ~MediaGalleriesDialogTest() override {}
   void SetUp() override {
     std::vector<base::string16> headers;
+    views_delegate_ = base::MakeUnique<views::TestViewsDelegate>();
     headers.push_back(base::string16());
     headers.push_back(base::ASCIIToUTF16("header2"));
     ON_CALL(controller_, GetSectionHeaders()).
         WillByDefault(Return(headers));
     EXPECT_CALL(controller_, GetSectionEntries(_)).
         Times(AnyNumber());
   }
 
   void TearDown() override {
     Mock::VerifyAndClearExpectations(&controller_);
   }
 
   NiceMock<MediaGalleriesDialogControllerMock>* controller() {
     return &controller_;
   }
 
  private:
   // TODO(gbillock): Get rid of this mock; make something specialized.
   NiceMock<MediaGalleriesDialogControllerMock> controller_;
+  std::unique_ptr<views::TestViewsDelegate> views_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogTest);
 };
 
 // Tests that checkboxes are initialized according to the contents of
 // permissions in the registry.
 TEST_F(MediaGalleriesDialogTest, InitializeCheckboxes) {
   MediaGalleriesDialogController::Entries attached_permissions;
   attached_permissions.push_back(
       MediaGalleriesDialogController::Entry(MakePrefInfoForTesting(1), true));
@@ skipping 82 matching lines @@
   MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2);
   attached_permissions.push_back(
       MediaGalleriesDialogController::Entry(gallery2, true));
   dialog.UpdateGalleries();
   EXPECT_EQ(2U, dialog.checkbox_map_.size());
 
   attached_permissions.pop_back();
   dialog.UpdateGalleries();
   EXPECT_EQ(1U, dialog.checkbox_map_.size());
 }