Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: media/audio/audio_system_impl.cc

Issue 2696253004: Revert of Switching AudioOutputAuthorizationHandler from using AudioManager interface to AudioSystem one. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/audio/audio_system_impl.h ('k') | media/audio/audio_system_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_system_impl.h" 5 #include "media/audio/audio_system_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/single_thread_task_runner.h" 8 #include "base/single_thread_task_runner.h"
9 #include "base/task_runner_util.h" 9 #include "base/task_runner_util.h"
10 #include "media/audio/audio_device_description.h"
11 #include "media/audio/audio_manager.h" 10 #include "media/audio/audio_manager.h"
12 11
13 // Using base::Unretained for |audio_manager_| is safe since it is deleted after 12 // Using base::Unretained for |audio_manager_| is safe since it is deleted after
14 // its task runner, and AudioSystemImpl is deleted on the UI thread after the IO 13 // its task runner, and AudioSystemImpl is deleted on the UI thread after the IO
15 // thread has been stopped and before |audio_manager_| deletion is scheduled. 14 // thread has been stopped and before |audio_manager_| deletion is scheduled.
16 namespace media { 15 namespace media {
17 16
18 namespace { 17 namespace {
19 18
20 AudioParameters GetInputParametersOnDeviceThread(AudioManager* audio_manager, 19 AudioParameters GetInputParametersOnDeviceThread(AudioManager* audio_manager,
21 const std::string& device_id) { 20 const std::string& device_id) {
22 DCHECK(audio_manager->GetTaskRunner()->BelongsToCurrentThread()); 21 DCHECK(audio_manager->GetTaskRunner()->BelongsToCurrentThread());
23 22
24 // TODO(olka): remove this when AudioManager::GetInputStreamParameters() 23 // TODO(olka): remove this when AudioManager::GetInputStreamParameters()
25 // returns invalid parameters if the device is not found. 24 // works this way on all the platforms.
26 if (!audio_manager->HasAudioInputDevices()) 25 if (!audio_manager->HasAudioInputDevices())
27 return AudioParameters(); 26 return AudioParameters();
28 27
29 return audio_manager->GetInputStreamParameters(device_id); 28 return audio_manager->GetInputStreamParameters(device_id);
30 } 29 }
31 30
32 AudioParameters GetOutputParametersOnDeviceThread(
33 AudioManager* audio_manager,
34 const std::string& device_id) {
35 DCHECK(audio_manager->GetTaskRunner()->BelongsToCurrentThread());
36
37 // TODO(olka): remove this when
38 // AudioManager::Get[Default]OutputStreamParameters() returns invalid
39 // parameters if the device is not found.
40 if (!audio_manager->HasAudioOutputDevices())
41 return AudioParameters();
42
43 return media::AudioDeviceDescription::IsDefaultDevice(device_id)
44 ? audio_manager->GetDefaultOutputStreamParameters()
45 : audio_manager->GetOutputStreamParameters(device_id);
46 }
47
48 } // namespace 31 } // namespace
49 32
50 AudioSystemImpl::AudioSystemImpl(AudioManager* audio_manager) 33 AudioSystemImpl::AudioSystemImpl(AudioManager* audio_manager)
51 : audio_manager_(audio_manager) { 34 : audio_manager_(audio_manager) {
52 DCHECK(audio_manager_); 35 DCHECK(audio_manager_);
53 AudioSystem::SetInstance(this); 36 AudioSystem::SetInstance(this);
54 } 37 }
55 38
56 AudioSystemImpl::~AudioSystemImpl() { 39 AudioSystemImpl::~AudioSystemImpl() {
57 AudioSystem::ClearInstance(this); 40 AudioSystem::ClearInstance(this);
(...skipping 14 matching lines...) Expand all
72 audio_manager_, device_id))); 55 audio_manager_, device_id)));
73 return; 56 return;
74 } 57 }
75 base::PostTaskAndReplyWithResult( 58 base::PostTaskAndReplyWithResult(
76 GetTaskRunner(), FROM_HERE, 59 GetTaskRunner(), FROM_HERE,
77 base::Bind(&GetInputParametersOnDeviceThread, 60 base::Bind(&GetInputParametersOnDeviceThread,
78 base::Unretained(audio_manager_), device_id), 61 base::Unretained(audio_manager_), device_id),
79 std::move(on_params_cb)); 62 std::move(on_params_cb));
80 } 63 }
81 64
82 void AudioSystemImpl::GetOutputStreamParameters(
83 const std::string& device_id,
84 OnAudioParamsCallback on_params_cb) const {
85 if (GetTaskRunner()->BelongsToCurrentThread()) {
86 GetTaskRunner()->PostTask(
87 FROM_HERE, base::Bind(on_params_cb, GetOutputParametersOnDeviceThread(
88 audio_manager_, device_id)));
89 return;
90 }
91 base::PostTaskAndReplyWithResult(
92 GetTaskRunner(), FROM_HERE,
93 base::Bind(&GetOutputParametersOnDeviceThread,
94 base::Unretained(audio_manager_), device_id),
95 std::move(on_params_cb));
96 }
97
98 void AudioSystemImpl::HasInputDevices(OnBoolCallback on_has_devices_cb) const { 65 void AudioSystemImpl::HasInputDevices(OnBoolCallback on_has_devices_cb) const {
99 if (GetTaskRunner()->BelongsToCurrentThread()) { 66 if (GetTaskRunner()->BelongsToCurrentThread()) {
100 GetTaskRunner()->PostTask( 67 GetTaskRunner()->PostTask(
101 FROM_HERE, 68 FROM_HERE,
102 base::Bind(on_has_devices_cb, audio_manager_->HasAudioInputDevices())); 69 base::Bind(on_has_devices_cb, audio_manager_->HasAudioInputDevices()));
103 return; 70 return;
104 } 71 }
105 base::PostTaskAndReplyWithResult( 72 base::PostTaskAndReplyWithResult(
106 GetTaskRunner(), FROM_HERE, 73 GetTaskRunner(), FROM_HERE,
107 base::Bind(&AudioManager::HasAudioInputDevices, 74 base::Bind(&AudioManager::HasAudioInputDevices,
108 base::Unretained(audio_manager_)), 75 base::Unretained(audio_manager_)),
109 std::move(on_has_devices_cb)); 76 std::move(on_has_devices_cb));
110 } 77 }
111 78
112 AudioManager* AudioSystemImpl::GetAudioManager() const { 79 AudioManager* AudioSystemImpl::GetAudioManager() const {
113 return audio_manager_; 80 return audio_manager_;
114 } 81 }
115 82
116 base::SingleThreadTaskRunner* AudioSystemImpl::GetTaskRunner() const { 83 base::SingleThreadTaskRunner* AudioSystemImpl::GetTaskRunner() const {
117 return audio_manager_->GetTaskRunner(); 84 return audio_manager_->GetTaskRunner();
118 } 85 }
119 86
120 } // namespace media 87 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/audio_system_impl.h ('k') | media/audio/audio_system_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698