Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2696203004: Revert of "Route DXGI Frame Statistics to VSyncProvider" (Closed)

Created:
3 years, 10 months ago by stanisc
Modified:
3 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Route DXGI Frame Statistics to VSyncProvider" This reverts the following commits related to this change. http://crrev.com/b5df120a181df5743a1ebd5f7cc6537a00097ee3 http://crrev.com/bc7ba6d60345cbd6b1c55945238e474b0164bee8 http://crrev.com/d5c055882dc5bf06a8930c6e7d6f52dee3489560 http://crrev.com/dd1d76988f2d7ae8f76a610bcbb03243e244436c This was an attempt to share eglGetSyncValuesCHROMIUM based VSyncProvider between Linux and Windows. The feature wasn't working anyway because eglGetSyncValuesCHROMIUM had to be reverted on ANGLE side due to video playback smoothness regression that it caused. That approach is now irrelevant because we are going to provide a mechanism for delivering a true GPU VSync signal. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2696203004 Cr-Commit-Position: refs/heads/master@{#451120} Committed: https://chromium.googlesource.com/chromium/src/+/858b96d1f311506dd39d5a881cfb9fe73cf85b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -207 lines) Patch
M gpu/ipc/service/image_transport_surface_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 2 chunks +0 lines, -20 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 3 chunks +36 lines, -25 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.h View 2 chunks +4 lines, -12 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.cc View 4 chunks +76 lines, -145 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
stanisc
PTAL!
3 years, 10 months ago (2017-02-16 01:51:05 UTC) #8
Ken Russell (switch to Gerrit)
John, could you help review this?
3 years, 10 months ago (2017-02-16 02:18:01 UTC) #10
jbauman
lgtm
3 years, 10 months ago (2017-02-16 02:24:57 UTC) #11
Ken Russell (switch to Gerrit)
lgtm based mainly on jbauman's review.
3 years, 10 months ago (2017-02-16 02:27:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696203004/1
3 years, 10 months ago (2017-02-16 18:26:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120729)
3 years, 10 months ago (2017-02-16 19:55:57 UTC) #16
Ken Russell (switch to Gerrit)
On 2017/02/16 19:55:57, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 10 months ago (2017-02-16 21:25:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696203004/1
3 years, 10 months ago (2017-02-16 21:27:51 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 22:28:37 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/858b96d1f311506dd39d5a881cfb...

Powered by Google App Engine
This is Rietveld 408576698