[debugger] implement inspector-facing API for code coverage.

[debugger] implement inspector-facing API for code coverage.

The inspector uses V8's API handles and should not access
V8 internals. This change makes sure it can use the coverage
data in an encapsulated way.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2696163002
Cr-Commit-Position: refs/heads/master@{#43231}
Committed: https://chromium.googlesource.com/v8/v8/+/c39123dd538f20ef63a8ef90689d935d260a70f7

[kozy, 2017-02-15 16:33:41]

https://codereview.chromium.org/2696163002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2696163002/diff/1/src/api.cc#newcode9528
src/api.cc:9528: return ToApiHandle<String>(range_->name);
Utils::ToLocal?

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.cc
File src/debug/debug-coverage.cc (right):

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.cc...
src/debug/debug-coverage.cc:141: Handle<String> name(info->DebugName(),
isolate);
Why GC couldn't happen for example here? Is it safe to use raw pointers to
SharedFunctionInfos?

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.h
File src/debug/debug-coverage.h (right):

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.h#...
src/debug/debug-coverage.h:36: class Coverage : public
std::vector<CoverageScript> {
I think that std::vector has non-virtual destructor. This code looks suspicious
to me.

[Yang, 2017-02-15 16:42:42]

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.cc
File src/debug/debug-coverage.cc (right):

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.cc...
src/debug/debug-coverage.cc:141: Handle<String> name(info->DebugName(),
isolate);
On 2017/02/15 16:33:41, kozy wrote:
> Why GC couldn't happen for example here? Is it safe to use raw pointers to
> SharedFunctionInfos?

Yes. No GC can happen. We assert that in the SharedToCounterMap as scope.

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.h
File src/debug/debug-coverage.h (right):

https://codereview.chromium.org/2696163002/diff/1/src/debug/debug-coverage.h#...
src/debug/debug-coverage.h:36: class Coverage : public
std::vector<CoverageScript> {
On 2017/02/15 16:33:41, kozy wrote:
> I think that std::vector has non-virtual destructor. This code looks
suspicious
> to me.

I'm not using any polymorphism here. The destructor of std::vector should run
after debug::Coverage.

[kozy, 2017-02-15 17:16:34]

thanks, lgtm.

[Yang, 2017-02-15 17:36:10]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 17:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 17:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 17:45:52]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Yang, 2017-02-16 07:33:13]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-16 07:33:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2696163002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2017-02-16 07:33:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 07:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 07:38:08]

Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/22761)

[Yang, 2017-02-16 08:00:42]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-16 08:00:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2696163002/#ps40001
(title: "fix test-debug")

[commit-bot: I haz the power, 2017-02-16 08:00:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 08:08:25]

Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Yang, 2017-02-16 08:09:30]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-16 08:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2696163002/#ps60001
(title: "one more shared export")

[commit-bot: I haz the power, 2017-02-16 08:09:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-02-16 08:28:22]

lgtm

[commit-bot: I haz the power, 2017-02-16 08:36:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487232570663160,
"parent_rev": "277b8e93de766c813522fcfb708fa043e98d5f9b", "commit_rev":
"c39123dd538f20ef63a8ef90689d935d260a70f7"}

[commit-bot: I haz the power, 2017-02-16 08:36:19]

Description was changed from

==========
[debugger] implement inspector-facing API for code coverage.

The inspector uses V8's API handles and should not access
V8 internals. This change makes sure it can use the coverage
data in an encapsulated way.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] implement inspector-facing API for code coverage.

The inspector uses V8's API handles and should not access
V8 internals. This change makes sure it can use the coverage
data in an encapsulated way.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2696163002
Cr-Commit-Position: refs/heads/master@{#43231}
Committed:
https://chromium.googlesource.com/v8/v8/+/c39123dd538f20ef63a8ef90689d935d260...
==========

[commit-bot: I haz the power, 2017-02-16 08:36:20]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/c39123dd538f20ef63a8ef90689d935d260...