Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2696093003: Always invalidate sticky constraints on the ancestor overflow layer (Closed)

Created:
3 years, 10 months ago by flackr
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Always invalidate sticky constraints on the ancestor overflow layer Previously we only invalidated sticky constraints on the ancestor overflow layer if the layout object had a paint layer, but we should use our enclosing layer (which may be the same object, its scroller or an ancestor with a PaintLayer) to ensure that we invalidate the constraint within the scroller. BUG=690580 Review-Url: https://codereview.chromium.org/2683313003 Cr-Commit-Position: refs/heads/master@{#449993} (cherry picked from commit b65f6264820a5c2e82aa1c9953b37ef34a4d02ec) Review-Url: https://codereview.chromium.org/2696093003 . Cr-Commit-Position: refs/branch-heads/2987@{#520} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/643a0f48f293e0ae53903353b5bb54ed28bb4165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
flackr
3 years, 10 months ago (2017-02-15 15:58:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
643a0f48f293e0ae53903353b5bb54ed28bb4165.

Powered by Google App Engine
This is Rietveld 408576698