Always invalidate sticky constraints on the ancestor overflow layer

Always invalidate sticky constraints on the ancestor overflow layer

Previously we only invalidated sticky constraints on the ancestor
overflow layer if the layout object had a paint layer, but we should use
our enclosing layer (which may be the same object, its scroller or
an ancestor with a PaintLayer) to ensure that we invalidate the constraint
within the scroller.

BUG=690580
Review-Url: https://codereview.chromium.org/2683313003
Cr-Commit-Position: refs/heads/master@{#449993}
Committed: https://chromium.googlesource.com/chromium/src/+/b65f6264820a5c2e82aa1c9953b37ef34a4d02ec

[flackr, 2017-02-10 22:03:01]

flackr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[flackr, 2017-02-10 22:03:01]

PTAL, this ensures that we invalidate the constraints even if the changed layout
object doesn't have a paint layer as it should still dirty the sticky
constraints.

[chrishtr, 2017-02-10 23:14:33]

lgtm

https://codereview.chromium.org/2683313003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp (right):

https://codereview.chromium.org/2683313003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp:295: "<div
style='flex: 1'>"
nit: indent 2

[flackr, 2017-02-13 15:53:54]

https://codereview.chromium.org/2683313003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp (right):

https://codereview.chromium.org/2683313003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp:295: "<div
style='flex: 1'>"
On 2017/02/10 23:14:33, chrishtr wrote:
> nit: indent 2

Done.

[flackr, 2017-02-13 15:53:58]

The CQ bit was checked by flackr@chromium.org

[flackr, 2017-02-13 15:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2683313003/#ps40001
(title: "Indentation.")

[commit-bot: I haz the power, 2017-02-13 15:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:39:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487001238455180,
"parent_rev": "677ee0b9f94556d026da1973c20efe6d659cc7ce", "commit_rev":
"b65f6264820a5c2e82aa1c9953b37ef34a4d02ec"}

[commit-bot: I haz the power, 2017-02-13 17:40:01]

Description was changed from

==========
Always invalidate sticky constraints on the ancestor overflow layer

Previously we only invalidated sticky constraints on the ancestor
overflow layer if the layout object had a paint layer, but we should use
our enclosing layer (which may be the same object, its scroller or
an ancestor with a PaintLayer) to ensure that we invalidate the constraint
within the scroller.

BUG=690580
==========

to

==========
Always invalidate sticky constraints on the ancestor overflow layer

Previously we only invalidated sticky constraints on the ancestor
overflow layer if the layout object had a paint layer, but we should use
our enclosing layer (which may be the same object, its scroller or
an ancestor with a PaintLayer) to ensure that we invalidate the constraint
within the scroller.

BUG=690580

Review-Url: https://codereview.chromium.org/2683313003
Cr-Commit-Position: refs/heads/master@{#449993}
Committed:
https://chromium.googlesource.com/chromium/src/+/b65f6264820a5c2e82aa1c9953b3...
==========

[commit-bot: I haz the power, 2017-02-13 17:40:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b65f6264820a5c2e82aa1c9953b3...