Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2695933005: [debugger] extend side effect free debug-evaluate to Array builtins. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] extend side effect free debug-evaluate to Array builtins. R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2695933005 Cr-Commit-Position: refs/heads/master@{#43371} Committed: https://chromium.googlesource.com/v8/v8/+/4a655cbe0c8368dd68e97d6c2ff3052a122b2cf4

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments. #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M src/bootstrapper.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 2 5 chunks +21 lines, -0 lines 0 comments Download
M test/debugger/debug/debug-evaluate-no-side-effect-builtins.js View 1 1 chunk +25 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Yang
3 years, 10 months ago (2017-02-16 14:01:15 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js File test/debugger/debug/debug-evaluate-no-side-effect-builtins.js (right): https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js#newcode24 test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:24: for (f of ["find"] ){//Object.getOwnPropertyNames(Array.prototype)) { This is ...
3 years, 10 months ago (2017-02-17 08:14:00 UTC) #2
Yang
https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js File test/debugger/debug/debug-evaluate-no-side-effect-builtins.js (right): https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js#newcode24 test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:24: for (f of ["find"] ){//Object.getOwnPropertyNames(Array.prototype)) { On 2017/02/17 08:14:00, ...
3 years, 10 months ago (2017-02-22 12:09:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695933005/20001
3 years, 10 months ago (2017-02-22 12:09:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/17389) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-22 12:27:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695933005/40001
3 years, 10 months ago (2017-02-22 13:05:03 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 13:29:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/4a655cbe0c8368dd68e97d6c2ff3052a122...

Powered by Google App Engine
This is Rietveld 408576698