[debugger] extend side effect free debug-evaluate to Array builtins.

[debugger] extend side effect free debug-evaluate to Array builtins.

R=jgruber@chromium.org
BUG=v8:5821
Review-Url: https://codereview.chromium.org/2695933005
Cr-Commit-Position: refs/heads/master@{#43371}
Committed: https://chromium.googlesource.com/v8/v8/+/4a655cbe0c8368dd68e97d6c2ff3052a122b2cf4

[jgruber, 2017-02-17 08:14:00]

lgtm

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
File test/debugger/debug/debug-evaluate-no-side-effect-builtins.js (right):

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:24: for (f of
["find"] ){//Object.getOwnPropertyNames(Array.prototype)) {
This is only testing "find" ;)

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:31: print(f);
Leftover?

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:36:
exec_state.frame(0).evaluate(`[1, 2, 3].${f}(()=>{});`, true);
Maybe we could have a list of {result, function_call_as_text} tuples to iterate
over, and then use the success function above. Just an idea, I'm also fine with
the unchecked result you have currently.

[Yang, 2017-02-22 12:09:32]

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
File test/debugger/debug/debug-evaluate-no-side-effect-builtins.js (right):

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:24: for (f of
["find"] ){//Object.getOwnPropertyNames(Array.prototype)) {
On 2017/02/17 08:14:00, jgruber wrote:
> This is only testing "find" ;)

oups :)

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:31: print(f);
On 2017/02/17 08:14:00, jgruber wrote:
> Leftover?

Removed.

https://codereview.chromium.org/2695933005/diff/1/test/debugger/debug/debug-e...
test/debugger/debug/debug-evaluate-no-side-effect-builtins.js:36:
exec_state.frame(0).evaluate(`[1, 2, 3].${f}(()=>{});`, true);
On 2017/02/17 08:14:00, jgruber wrote:
> Maybe we could have a list of {result, function_call_as_text} tuples to
iterate
> over, and then use the success function above. Just an idea, I'm also fine
with
> the unchecked result you have currently.

I don't want to make this too complicated :)

[Yang, 2017-02-22 12:09:37]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-22 12:09:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2695933005/#ps20001
(title: "address comments.")

[commit-bot: I haz the power, 2017-02-22 12:09:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 12:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 12:27:15]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[Yang, 2017-02-22 13:05:01]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-22 13:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2695933005/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-02-22 13:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 13:29:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487768701491380,
"parent_rev": "087e95ba6315576712a41276cd7b5c5da1131486", "commit_rev":
"4a655cbe0c8368dd68e97d6c2ff3052a122b2cf4"}

[commit-bot: I haz the power, 2017-02-22 13:29:45]

Description was changed from

==========
[debugger] extend side effect free debug-evaluate to Array builtins.

R=jgruber@chromium.org
BUG=v8:5821
==========

to

==========
[debugger] extend side effect free debug-evaluate to Array builtins.

R=jgruber@chromium.org
BUG=v8:5821

Review-Url: https://codereview.chromium.org/2695933005
Cr-Commit-Position: refs/heads/master@{#43371}
Committed:
https://chromium.googlesource.com/v8/v8/+/4a655cbe0c8368dd68e97d6c2ff3052a122...
==========

[commit-bot: I haz the power, 2017-02-22 13:29:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/4a655cbe0c8368dd68e97d6c2ff3052a122...