Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2695923005: Revert of Fix compile failure on Mac and Linux for build 57.0.2987.42 (Closed)

Created:
3 years, 10 months ago by mustaq
Modified:
3 years, 10 months ago
Reviewers:
lanwei
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Fix compile failure on Mac and Linux for build 57.0.2987.42 (patchset #1 id:1 of https://codereview.chromium.org/2683283003/ ) Reason for revert: Compile failure from previous revert: crbug.com/692248 Original issue's description: > Fix compile failure on Mac and Linux for build 57.0.2987.42 > > There is unused variable kMaxConceivablePlatformSlopRegionLengthDipsSquared > in touch_event_queue.cc. Now remove it. > > BUG=690758, 690759 > > Review-Url: https://codereview.chromium.org/2683283003 . > Cr-Commit-Position: refs/branch-heads/2987@{#427} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/1094e7d4cb256d1f57f5bb49e34577b72c727cf4 TBR=lanwei@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=692248 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2695923005 Cr-Commit-Position: refs/branch-heads/2987@{#513} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d3a63da18fc6ce031db92e61c6adbdc828fd9a6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mustaq
Created Revert of Fix compile failure on Mac and Linux for build 57.0.2987.42
3 years, 10 months ago (2017-02-14 23:31:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695923005/1
3 years, 10 months ago (2017-02-14 23:32:37 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-14 23:32:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695923005/1
3 years, 10 months ago (2017-02-14 23:34:46 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:36:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3a63da18fc6ce031db92e61c6ad...

Powered by Google App Engine
This is Rietveld 408576698