Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2683283003: Fix compile failure on Mac and Linux for build 57.0.2987.42 (Closed)

Created:
3 years, 10 months ago by lanwei
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix compile failure on Mac and Linux for build 57.0.2987.42 There is unused variable kMaxConceivablePlatformSlopRegionLengthDipsSquared in touch_event_queue.cc. Now remove it. BUG=690758, 690759 Review-Url: https://codereview.chromium.org/2683283003 . Cr-Commit-Position: refs/branch-heads/2987@{#427} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1094e7d4cb256d1f57f5bb49e34577b72c727cf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
lanwei
Committed patchset #1 (id:1) manually as 1094e7d4cb256d1f57f5bb49e34577b72c727cf4.
3 years, 10 months ago (2017-02-10 03:15:31 UTC) #7
mustaq
3 years, 10 months ago (2017-02-14 23:31:13 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2695923005/ by mustaq@chromium.org.

The reason for reverting is: Compile failure from previous revert:
crbug.com/692248.

Powered by Google App Engine
This is Rietveld 408576698