Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2695923003: Don't notify SUSPENDED state in ChildMemoryCoordinator::PurgeMemory() (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't notify SUSPENDED state in ChildMemoryCoordinator::PurgeMemory() All purging logic in MemoryCoordinatorClients has moved to OnPurgeMemory(). We don't need to call Notifiy(SUSPENDED) anymore. BUG=684287 Review-Url: https://codereview.chromium.org/2695923003 Cr-Commit-Position: refs/heads/master@{#450300} Committed: https://chromium.googlesource.com/chromium/src/+/7a3481c035a42c8fef365f2f9d94c78305cee048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/child/memory/child_memory_coordinator_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
bashi
PTAL tasak@: I think we moved all purging logic to OnPurgeMemory(). Please let me know ...
3 years, 10 months ago (2017-02-14 08:18:16 UTC) #4
haraken
LGTM if tasak@ is happy.
3 years, 10 months ago (2017-02-14 08:19:02 UTC) #5
tasak
lgtm
3 years, 10 months ago (2017-02-14 08:21:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695923003/1
3 years, 10 months ago (2017-02-14 09:16:48 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 09:20:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a3481c035a42c8fef365f2f9d94...

Powered by Google App Engine
This is Rietveld 408576698