Add PurgeMemory() method for ChildMemoryCoordinator.mojom

Add PurgeMemory() method for ChildMemoryCoordinator.mojom

This method enables the browser process (MemoryCoordinator) to request
a renderer to purge memory.

BUG=684287
Review-Url: https://codereview.chromium.org/2685263002
Cr-Commit-Position: refs/heads/master@{#450294}
Committed: https://chromium.googlesource.com/chromium/src/+/f0056e78a01fe12008eec015c18f28c766d3cf58

[bashi, 2017-02-10 04:23:06]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 04:23:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-02-10 04:25:16]

bashi@chromium.org changed reviewers:
+ chrisha@chromium.org, haraken@chromium.org

[bashi, 2017-02-10 04:25:16]

PTAL

I think we need this as the browser would want to ask a renderer to purge
memory.

[bashi, 2017-02-10 04:48:23]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 04:48:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 05:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 05:44:05]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-02-14 02:25:56]

chrisha@, haraken@: does this make sense? I think we need a mojo message to ask
renderers to purge their memory.

[haraken, 2017-02-14 02:30:37]

Sorry, I was missing this CL... LGTM.

[bashi, 2017-02-14 02:31:51]

bashi@chromium.org changed reviewers:
+ dcheng@chromium.org

[bashi, 2017-02-14 02:31:52]

dcheng@: could you review ChildMemoryCoordinator.mojom ?

[dcheng, 2017-02-14 07:48:19]

lgtm

https://codereview.chromium.org/2685263002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_coordinator_impl_unittest.cc (right):

https://codereview.chromium.org/2685263002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator_impl_unittest.cc:65: is_state_changed_
= true;
Nit: it reads slightly more smoothly to call this:

did_change_state_

or just

state_changed_

https://codereview.chromium.org/2685263002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator_impl_unittest.cc:252: auto child =
coordinator_->CreateChildMemoryCoordinator(1);
Nit: auto*

https://codereview.chromium.org/2685263002/diff/20001/content/common/child_me...
File content/common/child_memory_coordinator.mojom (right):

https://codereview.chromium.org/2685263002/diff/20001/content/common/child_me...
content/common/child_memory_coordinator.mojom:24: // Requests purging memory.
Nit: I'd suggest rewording this comment to include examples of things child
processes should do in response to this callback, e.g.:

Requests the child process to purge memory (e.g. by dropping caches that can be
easily rebuilt).

[bashi, 2017-02-14 08:02:36]

https://codereview.chromium.org/2685263002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_coordinator_impl_unittest.cc (right):

https://codereview.chromium.org/2685263002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator_impl_unittest.cc:65: is_state_changed_
= true;
On 2017/02/14 07:48:18, dcheng wrote:
> Nit: it reads slightly more smoothly to call this:
> 
> did_change_state_
> 
> or just
> 
> state_changed_

Changed to did_state_changed. Thanks for the suggestion!

https://codereview.chromium.org/2685263002/diff/20001/content/browser/memory/...
content/browser/memory/memory_coordinator_impl_unittest.cc:252: auto child =
coordinator_->CreateChildMemoryCoordinator(1);
On 2017/02/14 07:48:18, dcheng wrote:
> Nit: auto*

Done.

https://codereview.chromium.org/2685263002/diff/20001/content/common/child_me...
File content/common/child_memory_coordinator.mojom (right):

https://codereview.chromium.org/2685263002/diff/20001/content/common/child_me...
content/common/child_memory_coordinator.mojom:24: // Requests purging memory.
On 2017/02/14 07:48:18, dcheng wrote:
> Nit: I'd suggest rewording this comment to include examples of things child
> processes should do in response to this callback, e.g.:
> 
> Requests the child process to purge memory (e.g. by dropping caches that can
be
> easily rebuilt).
> 

Done.

[bashi, 2017-02-14 08:03:12]

The CQ bit was checked by bashi@chromium.org

[bashi, 2017-02-14 08:03:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2685263002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2017-02-14 08:03:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 08:52:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487059392576110,
"parent_rev": "3245561158dde6808bd24b3322304369af52abac", "commit_rev":
"f0056e78a01fe12008eec015c18f28c766d3cf58"}

[commit-bot: I haz the power, 2017-02-14 08:53:35]

Description was changed from

==========
Add PurgeMemory() method for ChildMemoryCoordinator.mojom

This method enables the browser process (MemoryCoordinator) to request
a renderer to purge memory.

BUG=684287
==========

to

==========
Add PurgeMemory() method for ChildMemoryCoordinator.mojom

This method enables the browser process (MemoryCoordinator) to request
a renderer to purge memory.

BUG=684287

Review-Url: https://codereview.chromium.org/2685263002
Cr-Commit-Position: refs/heads/master@{#450294}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0056e78a01fe12008eec015c18f...
==========

[commit-bot: I haz the power, 2017-02-14 08:53:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f0056e78a01fe12008eec015c18f...