Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2695833003: Revert of Select correct copy method for DoCopySubTexture (Closed)

Created:
3 years, 10 months ago by marcheu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Select correct copy method for DoCopySubTexture (patchset #1 id:1 of https://codereview.chromium.org/2680703003/ ) Reason for revert: The new DoCopySubTexture causes a performance regression on WebGL on Chrome OS. BUG=chromium:691741 TEST=on celes, webgl performance is back to normal Original issue's description: > Select correct copy method for DoCopySubTexture > > BUG=687180 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2680703003 > Cr-Commit-Position: refs/heads/master@{#448905} > Committed: https://chromium.googlesource.com/chromium/src/+/a8450b810e89819add240a319586c899683dff9f TBR=kbr@chromium.org,zmo@chromium.org,yunchao.he@intel.com,dongseong.hwang@intel.com,qiankun.miao@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=687180 Review-Url: https://codereview.chromium.org/2695833003 Cr-Commit-Position: refs/heads/master@{#450212} Committed: https://chromium.googlesource.com/chromium/src/+/2404c8ae0098fa7cae48db92222240293a9d2689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -79 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 1 chunk +1 line, -32 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +9 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 9 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
marcheu
Created Revert of Select correct copy method for DoCopySubTexture
3 years, 10 months ago (2017-02-14 01:03:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695833003/1
3 years, 10 months ago (2017-02-14 01:04:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695833003/1
3 years, 10 months ago (2017-02-14 01:08:38 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 02:49:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2404c8ae0098fa7cae48db922222...

Powered by Google App Engine
This is Rietveld 408576698