Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2695813007: Reland Support multiple TTS voices on Windows. (Closed)

Created:
3 years, 10 months ago by rongjie
Modified:
3 years, 10 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Support multiple TTS voices on Windows. Windows XP is no longer supported. Original review: https://codereview.chromium.org/97793002 BUG=88059 R=dtseng@chromium.org, dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/2695813007 Cr-Commit-Position: refs/heads/master@{#451006} Committed: https://chromium.googlesource.com/chromium/src/+/953322582e01e05f831456fecea0d48af331f16f

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Fix syntax error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -14 lines) Patch
M chrome/browser/speech/tts_win.cc View 1 2 6 chunks +95 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
rongjie
3 years, 10 months ago (2017-02-16 00:13:22 UTC) #1
dmazzoni
lgtm Let's try it and see...
3 years, 10 months ago (2017-02-16 00:20:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695813007/1
3 years, 10 months ago (2017-02-16 00:21:37 UTC) #4
rongjie
Fix typo. Is it possible to terminate the previous tryjob?
3 years, 10 months ago (2017-02-16 00:51:20 UTC) #5
dmazzoni
Don't worry about cancelling the previous jobs, they're superceded now.
3 years, 10 months ago (2017-02-16 01:12:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695813007/20001
3 years, 10 months ago (2017-02-16 01:12:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/367492) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 10 months ago (2017-02-16 01:44:18 UTC) #11
rongjie
Add base:: for WideToUTF8 and .get() for voice_token
3 years, 10 months ago (2017-02-16 05:02:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695813007/60001
3 years, 10 months ago (2017-02-16 16:08:20 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 17:41:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/953322582e01e05f831456fecea0...

Powered by Google App Engine
This is Rietveld 408576698