Support multiple TTS voices on Windows.

Support multiple TTS voices on Windows.

BUG=88059
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240810

[David Tseng, 2013-12-07 00:49:38]

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win.cc
File chrome/browser/speech/tts_win.cc (right):

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win...
chrome/browser/speech/tts_win.cc:194: return;
Do we want to let the js client know there was an error retrieving voices?

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win...
chrome/browser/speech/tts_win.cc:239: }
Does this fetch voices across multiple tts engines? From my cursory reading of
this code, it doesn't seem to?

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win...
chrome/browser/speech/tts_win.cc:299:
speech_synthesizer_->SetVoice(voice_token);
Did you notice any performance drawbacks with doing a voice lookup every time we
speak? Perhaps return earlier if the current voice is the requested voice?

[dmazzoni, 2013-12-09 17:12:24]

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win.cc
File chrome/browser/speech/tts_win.cc (right):

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win...
chrome/browser/speech/tts_win.cc:194: return;
On 2013/12/07 00:49:39, David Tseng wrote:
> Do we want to let the js client know there was an error retrieving voices?

We don't have a mechanism for this currently, i.e. getVoices just returns a list
of voices from all sources (native and extensions), it doesn't have a way to say
that one of the two failed for some reason.

In practice I've never seen this fail, even when speech is in use by another
app. I think it'd be worth considering passing information through if we
encounter a specific error in the wild that app developers might want to handle
- but absent any specific example I think it's fine to just not return any
native voices, and let the app use Google Network Speech.

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win...
chrome/browser/speech/tts_win.cc:239: }
On 2013/12/07 00:49:39, David Tseng wrote:
> Does this fetch voices across multiple tts engines? From my cursory reading of
> this code, it doesn't seem to?

SPCAT_VOICES returns voices from all engines in one big list. It's basically
just iterating over certain types of tokens in the registry.

https://codereview.chromium.org/97793002/diff/1/chrome/browser/speech/tts_win...
chrome/browser/speech/tts_win.cc:299:
speech_synthesizer_->SetVoice(voice_token);
On 2013/12/07 00:49:39, David Tseng wrote:
> Did you notice any performance drawbacks with doing a voice lookup every time
we
> speak? Perhaps return earlier if the current voice is the requested voice?

I didn't notice anything, but that's a good idea. Done.

[dmazzoni, 2013-12-11 21:35:46]

PTAL?

[David Tseng, 2013-12-13 20:49:50]

LGTM


On Wed, Dec 11, 2013 at 1:35 PM, <dmazzoni@chromium.org> wrote:

> PTAL?
>
> https://codereview.chromium.org/97793002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-13 20:53:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/97793002/20001

[commit-bot: I haz the power, 2013-12-14 00:04:27]

Change committed as 240810