Reorder setting of zooming, to prevent reflowing and size mismatch.

Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes missing borders or rendering artifacts.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

By setting zoom factor before forcing layout, the final size is reached the first
time around, and the window size should be correct.

BUG=691375
Review-Url: https://codereview.chromium.org/2695723002
Cr-Commit-Position: refs/heads/master@{#450513}
Committed: https://chromium.googlesource.com/chromium/src/+/1b3b57df0600ecc1efa08e17d12110c04accba71

[Karl Øygard, 2017-02-13 13:59:31]

The CQ bit was checked by karlo@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 13:59:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 15:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 15:34:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Karl Øygard, 2017-02-13 20:10:32]

Description was changed from

==========
Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes rendering artifacts or missing borders,
respectively.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

BUG=691375
==========

to

==========
Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes rendering artifacts or missing borders,
respectively.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

By setting zoom factor before forcing layout, the final size is reached the
first
time around, and the window size should be correct.


BUG=691375
==========

[Karl Øygard, 2017-02-14 09:00:02]

The CQ bit was checked by karlo@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 09:00:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 12:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 12:04:52]

Dry run: This issue passed the CQ dry run.

[Karl Øygard, 2017-02-14 20:41:18]

Description was changed from

==========
Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes rendering artifacts or missing borders,
respectively.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

By setting zoom factor before forcing layout, the final size is reached the
first
time around, and the window size should be correct.


BUG=691375
==========

to

==========
Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes missing borders or rendering artifacts.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

By setting zoom factor before forcing layout, the final size is reached the
first
time around, and the window size should be correct.

BUG=691375
==========

[Karl Øygard, 2017-02-14 20:41:19]

karlo@opera.com changed reviewers:
+ tkent@chromium.org

[Karl Øygard, 2017-02-14 20:43:20]

ptal

[tkent, 2017-02-14 22:52:30]

lgtm.  Thanks!

[tkent, 2017-02-14 22:52:33]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:53:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:30:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487112753590090,
"parent_rev": "12bf3676e0ffd3f017c5f8f2cf0e9c2f4175ca1e", "commit_rev":
"1b3b57df0600ecc1efa08e17d12110c04accba71"}

[commit-bot: I haz the power, 2017-02-14 23:31:33]

Description was changed from

==========
Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes missing borders or rendering artifacts.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

By setting zoom factor before forcing layout, the final size is reached the
first
time around, and the window size should be correct.

BUG=691375
==========

to

==========
Reorder setting of zooming, to prevent reflowing and size mismatch.

When zooming is applied to the document, the color suggestion picker can lose
or gain bottom pixels, which causes missing borders or rendering artifacts.

This appears to be caused by some unfortunate assumptions and interactions
in Source/web/resources/colorSuggestionPicker.js and friends.

The color picker is a separate window, and the contents of the window is
generated in ColorChooserPopupUIController.cpp.  colorSuggestionPicker.js
resizes the window to exactly fit the content, but the zoom factor is applied
afterwards, causing an additional reflow (see WebPagePopupImpl.cpp:329).
There is no guarantee that the zoomed contents will fit the window any more,
and much of the time it doesn't.

By setting zoom factor before forcing layout, the final size is reached the
first
time around, and the window size should be correct.

BUG=691375

Review-Url: https://codereview.chromium.org/2695723002
Cr-Commit-Position: refs/heads/master@{#450513}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b3b57df0600ecc1efa08e17d121...
==========

[commit-bot: I haz the power, 2017-02-14 23:31:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b3b57df0600ecc1efa08e17d121...