third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2695723002: Reorder setting of zooming, to prevent reflowing and size mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2695723002: Reorder setting of zooming, to prevent reflowing and size mismatch. (Closed)

Patch Set: Rebaselined test cases. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 19243199a405c9b8bca457eb47aac17b3f695671..3da1db0c659446a78f615111a5b9454ddf0f2bf5 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -326,10 +326,10 @@ bool WebPagePopupImpl::initializePage() {

RefPtr<SharedBuffer> data = SharedBuffer::create();

m_popupClient->writeDocument(data.get());

+ frame->setPageZoomFactor(m_popupClient->zoomFactor());

frame->loader().load(FrameLoadRequest(

0, blankURL(), SubstituteData(data, "text/html", "UTF-8", KURL(),

ForceSynchronousLoad)));

- frame->setPageZoomFactor(m_popupClient->zoomFactor());

return true;

}