Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2695653005: Revert of Remove SIMD.js from V8. (Closed)

Created:
3 years, 10 months ago by Franzi
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com, Michael Hablich, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove SIMD.js from V8. (patchset #7 id:120001 of https://codereview.chromium.org/2684313003/ ) Reason for revert: Breaks Node integration build. Original issue's description: > Remove SIMD.js from V8. > > LOG=Y > BUG=v8:4124, v8:5948 > R=bradnelson@chromium.org,bmeurer@chromium.org,jochen@chromium.org,hpayer@chromium.org,danno@chromium.org > > Review-Url: https://codereview.chromium.org/2684313003 > Cr-Original-Commit-Position: refs/heads/master@{#43162} > Committed: https://chromium.googlesource.com/v8/v8/+/d170c57ab996d00c4665a9d865bd5754a1806c6c > Review-Url: https://codereview.chromium.org/2684313003 > Cr-Commit-Position: refs/heads/master@{#43169} > Committed: https://chromium.googlesource.com/v8/v8/+/a9b59a11f1bfe069afabe5567f919727456f1f12 TBR=bradnelson@chromium.org,bmeurer@chromium.org,jochen@chromium.org,hpayer@chromium.org,danno@chromium.org,bradnelson@google.com,machenbach@chromium.org,bbudge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124, v8:5948 Review-Url: https://codereview.chromium.org/2695653005 Cr-Commit-Position: refs/heads/master@{#43170} Committed: https://chromium.googlesource.com/v8/v8/+/a386eb4f04b258a9e76cd0249146b4c856ee1cd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5212 lines, -67 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M gypfiles/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 2 chunks +10 lines, -4 lines 0 comments Download
M include/v8-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ast/ast-types.h View 4 chunks +20 lines, -13 lines 0 comments Download
M src/ast/ast-types.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M src/builtins/builtins-array.cc View 6 chunks +64 lines, -4 lines 0 comments Download
M src/code-factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 15 chunks +177 lines, -10 lines 0 comments Download
M src/code-stubs.h View 3 chunks +26 lines, -1 line 0 comments Download
M src/code-stubs.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/types.h View 2 chunks +13 lines, -11 lines 0 comments Download
M src/compiler/types.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/contexts.h View 4 chunks +10 lines, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/heap-symbols.h View 4 chunks +20 lines, -0 lines 0 comments Download
M src/heap/heap.h View 3 chunks +27 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +18 lines, -0 lines 0 comments Download
A src/js/harmony-simd.js View 1 chunk +923 lines, -0 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -0 lines 0 comments Download
M src/json-stringifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.h View 5 chunks +89 lines, -0 lines 0 comments Download
M src/objects.cc View 14 chunks +177 lines, -5 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/objects-inl.h View 9 chunks +124 lines, -2 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/profiler/heap-snapshot-generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +311 lines, -0 lines 0 comments Download
A src/runtime/runtime-simd.cc View 1 chunk +1016 lines, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/type-hints.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/type-hints.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/ast-types-fuzz.h View 2 chunks +13 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +204 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M test/cctest/test-object.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/cctest/test-simd.cc View 1 chunk +129 lines, -0 lines 0 comments Download
M test/mjsunit/double-equals.js View 2 chunks +8 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/simd.js View 1 chunk +636 lines, -0 lines 0 comments Download
M test/mjsunit/messages.js View 2 chunks +6 lines, -0 lines 0 comments Download
M test/perf.isolate View 1 chunk +1 line, -0 lines 0 comments Download
A test/simdjs/SimdJs.json View 1 chunk +244 lines, -0 lines 0 comments Download
A test/simdjs/generate.py View 1 chunk +60 lines, -0 lines 0 comments Download
A test/simdjs/harness-adapt.js View 1 chunk +40 lines, -0 lines 0 comments Download
A test/simdjs/harness-finish.js View 1 chunk +26 lines, -0 lines 0 comments Download
A test/simdjs/simdjs.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A test/simdjs/simdjs.isolate View 1 chunk +14 lines, -0 lines 0 comments Download
A test/simdjs/simdjs.status View 1 chunk +34 lines, -0 lines 0 comments Download
A test/simdjs/testcfg.py View 1 chunk +57 lines, -0 lines 0 comments Download
M tools/try_perf.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Franzi
Created Revert of Remove SIMD.js from V8.
3 years, 10 months ago (2017-02-13 21:33:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695653005/1
3 years, 10 months ago (2017-02-13 21:33:13 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 21:33:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a386eb4f04b258a9e76cd0249146b4c856e...

Powered by Google App Engine
This is Rietveld 408576698