Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2684313003: Remove SIMD.js from V8. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com, Michael Hablich, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebaseline Ignition tests. #

Patch Set 3 : Rebase. #

Patch Set 4 : Remove more SIMD.js tests. #

Patch Set 5 : Remove more SIMD.js stuff. #

Patch Set 6 : Remove stray SIMD code that caused link to fail on Windows. #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -5212 lines) Patch
M .gitignore View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M gypfiles/all.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M include/v8-profiler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ast/ast-types.h View 4 chunks +13 lines, -20 lines 0 comments Download
M src/ast/ast-types.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/bootstrapper.cc View 1 2 2 chunks +0 lines, -34 lines 0 comments Download
M src/builtins/builtins-array.cc View 6 chunks +4 lines, -64 lines 0 comments Download
M src/code-factory.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-factory.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 15 chunks +10 lines, -177 lines 0 comments Download
M src/code-stubs.h View 1 2 3 chunks +1 line, -26 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 chunks +0 lines, -27 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/types.h View 1 2 2 chunks +11 lines, -13 lines 0 comments Download
M src/compiler/types.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/contexts.h View 1 2 4 chunks +0 lines, -10 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 2 chunks +0 lines, -22 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/heap-symbols.h View 4 chunks +0 lines, -20 lines 0 comments Download
M src/heap/heap.h View 1 2 3 chunks +0 lines, -27 lines 0 comments Download
M src/heap/heap.cc View 1 2 2 chunks +0 lines, -31 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/interface-descriptors.h View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
D src/js/harmony-simd.js View 1 chunk +0 lines, -923 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/json-stringifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 5 chunks +0 lines, -89 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 14 chunks +5 lines, -177 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M src/objects-inl.h View 1 2 9 chunks +2 lines, -124 lines 0 comments Download
M src/objects-printer.cc View 1 2 2 chunks +0 lines, -56 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/profiler/heap-snapshot-generator.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 2 2 chunks +0 lines, -311 lines 0 comments Download
D src/runtime/runtime-simd.cc View 1 chunk +0 lines, -1016 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/type-hints.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/type-hints.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/v8.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/BUILD.gn View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/ast-types-fuzz.h View 2 chunks +1 line, -13 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 2 chunks +0 lines, -204 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M test/cctest/test-object.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D test/cctest/test-simd.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M test/mjsunit/double-equals.js View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
D test/mjsunit/harmony/simd.js View 1 2 3 1 chunk +0 lines, -636 lines 0 comments Download
M test/mjsunit/messages.js View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M test/perf.isolate View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D test/simdjs/SimdJs.json View 1 2 3 1 chunk +0 lines, -244 lines 0 comments Download
D test/simdjs/generate.py View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
D test/simdjs/harness-adapt.js View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
D test/simdjs/harness-finish.js View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
D test/simdjs/simdjs.gyp View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
D test/simdjs/simdjs.isolate View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
D test/simdjs/simdjs.status View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D test/simdjs/testcfg.py View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
M tools/try_perf.py View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 83 (52 generated)
bbudge
isolate tests fail. Not sure how to disable those. Otherwise, it looks like everything else ...
3 years, 10 months ago (2017-02-10 21:30:19 UTC) #20
bradnelson
lgtm Wow. Shocking amount of effort that went into that. This highlights to me the ...
3 years, 10 months ago (2017-02-12 05:27:10 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313003/100001
3 years, 10 months ago (2017-02-12 05:27:44 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34540)
3 years, 10 months ago (2017-02-12 05:31:14 UTC) #28
bradnelson
Could we get OWNERS from: bmeurer, jochen, hpayer As this touches lots of places. NOTE: ...
3 years, 10 months ago (2017-02-12 05:38:29 UTC) #31
Benedikt Meurer
On 2017/02/12 05:38:29, bradnelson wrote: > Could we get OWNERS from: > bmeurer, jochen, hpayer ...
3 years, 10 months ago (2017-02-12 07:22:10 UTC) #32
bradn
Now need jochen or hpayer for the remaining bits in the GC.
3 years, 10 months ago (2017-02-12 07:26:23 UTC) #34
Michael Lippautz
On 2017/02/12 07:26:23, bradn wrote: > Now need jochen or hpayer for the remaining bits ...
3 years, 10 months ago (2017-02-12 12:24:58 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313003/100001
3 years, 10 months ago (2017-02-12 16:20:32 UTC) #37
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-12 16:22:45 UTC) #39
bbudge
On 2017/02/12 05:27:10, bradnelson wrote: > lgtm > > Wow. Shocking amount of effort that ...
3 years, 10 months ago (2017-02-12 19:57:38 UTC) #40
Hannes Payer (out of office)
Please also remove kSimd128Unaligned from AllocationAlignment in globals.h lgtm
3 years, 10 months ago (2017-02-13 08:25:19 UTC) #45
ivica.bogosavljevic
On 2017/02/12 05:27:10, bradnelson wrote: > lgtm > > Wow. Shocking amount of effort that ...
3 years, 10 months ago (2017-02-13 14:32:17 UTC) #46
bradn
We're focusing forward going SIMD effort on WebAssembly SIMD. SIMD.js is being used as a ...
3 years, 10 months ago (2017-02-13 15:56:35 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313003/120001
3 years, 10 months ago (2017-02-13 15:57:01 UTC) #50
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/v8/v8/+/d170c57ab996d00c4665a9d865bd5754a1806c6c
3 years, 10 months ago (2017-02-13 15:59:36 UTC) #54
Michael Achenbach
Why did this large CL land with notry? It broke the main waterfall and the ...
3 years, 10 months ago (2017-02-13 17:09:48 UTC) #55
bradn
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2691903003/ by bradnelson@google.com. ...
3 years, 10 months ago (2017-02-13 17:45:04 UTC) #56
bradnelson
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2692933002/ by bradnelson@chromium.org. ...
3 years, 10 months ago (2017-02-13 18:11:32 UTC) #57
bbudge
On 2017/02/13 08:25:19, Hannes Payer wrote: > Please also remove kSimd128Unaligned from AllocationAlignment in globals.h ...
3 years, 10 months ago (2017-02-13 18:43:20 UTC) #58
Michael Achenbach
Before you can rip out the .isolate stuff, you need to tell the infrastructure to ...
3 years, 10 months ago (2017-02-13 19:16:15 UTC) #59
Michael Achenbach
On 2017/02/13 19:16:15, Michael Achenbach wrote: > Before you can rip out the .isolate stuff, ...
3 years, 10 months ago (2017-02-13 19:18:24 UTC) #60
Michael Achenbach
On 2017/02/13 19:18:24, Michael Achenbach wrote: > On 2017/02/13 19:16:15, Michael Achenbach wrote: > > ...
3 years, 10 months ago (2017-02-13 19:26:46 UTC) #61
Michael Achenbach
On 2017/02/13 19:26:46, Michael Achenbach wrote: > On 2017/02/13 19:18:24, Michael Achenbach wrote: > > ...
3 years, 10 months ago (2017-02-13 20:07:04 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313003/120001
3 years, 10 months ago (2017-02-13 20:40:58 UTC) #71
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/v8/v8/+/a9b59a11f1bfe069afabe5567f919727456f1f12
3 years, 10 months ago (2017-02-13 20:43:21 UTC) #74
Franzi
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2695653005/ by franzih@chromium.org. ...
3 years, 10 months ago (2017-02-13 21:33:07 UTC) #75
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313003/120001
3 years, 10 months ago (2017-02-14 06:55:11 UTC) #78
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/v8/v8/+/deabb19abc3328149ed76990cdd3a1d5e4e5b3ed
3 years, 10 months ago (2017-02-14 06:57:37 UTC) #81
agrieve
On 2017/02/14 06:57:37, commit-bot: I haz the power wrote: > Committed patchset #7 (id:120001) as ...
3 years, 10 months ago (2017-02-14 20:40:58 UTC) #82
bbudge
3 years, 10 months ago (2017-02-14 21:52:50 UTC) #83
Message was sent while issue was closed.
On 2017/02/14 20:40:58, agrieve wrote:
> On 2017/02/14 06:57:37, commit-bot: I haz the power wrote:
> > Committed patchset #7 (id:120001) as
> >
>
https://chromium.googlesource.com/v8/v8/+/deabb19abc3328149ed76990cdd3a1d5e4e...
> 
> FYI - this shrank Chrome.apk by 468kb!

Wow! I didn't expect that much. There should be at least a small performance
gain as well.

Powered by Google App Engine
This is Rietveld 408576698