Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2695403003: Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conf… (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conflict with LoadLibraryW. Update use of IsolateData in Dartium's vm service. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/ab212fedb32a4f38ee0b1f15a8dc39e04f812504

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M runtime/bin/extensions.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/bin/extensions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/extensions_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/extensions_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/extensions_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/extensions_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/extensions_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/snapshot_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice_dartium.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-16 22:15:05 UTC) #2
zra
lgtm https://codereview.chromium.org/2695403003/diff/1/runtime/bin/extensions.h File runtime/bin/extensions.h (right): https://codereview.chromium.org/2695403003/diff/1/runtime/bin/extensions.h#newcode23 runtime/bin/extensions.h:23: static void* LoadExtensionLibrary(const char* library_file); Add comment warning ...
3 years, 10 months ago (2017-02-16 22:18:17 UTC) #3
rmacnak
https://codereview.chromium.org/2695403003/diff/1/runtime/bin/extensions.h File runtime/bin/extensions.h (right): https://codereview.chromium.org/2695403003/diff/1/runtime/bin/extensions.h#newcode23 runtime/bin/extensions.h:23: static void* LoadExtensionLibrary(const char* library_file); On 2017/02/16 22:18:17, zra ...
3 years, 10 months ago (2017-02-16 22:21:30 UTC) #4
rmacnak
3 years, 10 months ago (2017-02-16 22:22:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ab212fedb32a4f38ee0b1f15a8dc39e04f812504 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698