Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: runtime/bin/extensions.h

Issue 2695403003: Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conf… (Closed)
Patch Set: comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/extensions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions.h
diff --git a/runtime/bin/extensions.h b/runtime/bin/extensions.h
index d4c7b33001d453f5efeca1d2a284deebeefe1688..aba3bff927beb43f2b0e013e723770521197584b 100644
--- a/runtime/bin/extensions.h
+++ b/runtime/bin/extensions.h
@@ -20,7 +20,9 @@ class Extensions {
Dart_Handle parent_library);
// Platform-specific implementations.
- static void* LoadLibrary(const char* library_file);
+ // Don't rename LoadExtensionLibrary to LoadLibrary since on Windows it
+ // conflicts with LoadLibraryW after mangling.
+ static void* LoadExtensionLibrary(const char* library_file);
static void* ResolveSymbol(void* lib_handle, const char* symbol);
static void UnloadLibrary(void* lib_handle);
« no previous file with comments | « no previous file | runtime/bin/extensions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698