Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conf…

runtime/bin/extensions.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_BIN_EXTENSIONS_H_
 #define RUNTIME_BIN_EXTENSIONS_H_
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 namespace dart {
 namespace bin {
 
 class Extensions {
  public:
   // TODO(whesse): Make extension load from a relative path relative to
   // the library it is in.  Currently loads from current working directory.
   static Dart_Handle LoadExtension(const char* extension_directory,
                                    const char* extension_name,
                                    Dart_Handle parent_library);
 
   // Platform-specific implementations.
-  static void* LoadLibrary(const char* library_file);
+  static void* LoadExtensionLibrary(const char* library_file);

[zra, 2017/02/16 22:18:17]

Add comment warning against re-nameing to LoadLibrary.

[rmacnak, 2017/02/16 22:21:30]

Done.

   static void* ResolveSymbol(void* lib_handle, const char* symbol);
   static void UnloadLibrary(void* lib_handle);
 
  private:
   static Dart_Handle GetError();
 
   static void* MakePathAndResolve(const char* dir, const char* name);
   static void* ResolveAbsPathExtension(const char* extension_path);
   static void* ResolveExtension(const char* extensioion_directory,
                                 const char* extension_name);
 
   // The returned string is scope allocated.
   static const char* Concatenate(const char** strings);
 
   DISALLOW_ALLOCATION();
   DISALLOW_IMPLICIT_CONSTRUCTORS(Extensions);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // RUNTIME_BIN_EXTENSIONS_H_